Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(protocol): Wrong calculation when minting ERC20 tokens #13250

Merged
merged 1 commit into from
Mar 3, 2023

Conversation

jscriptcoder
Copy link
Contributor

@jscriptcoder jscriptcoder commented Mar 3, 2023

There was a small mistake in the calculation of the amount to mint. The number of tokens should be multiplied by 10^decimals

@codecov
Copy link

codecov bot commented Mar 3, 2023

Codecov Report

Merging #13250 (0a1ec9a) into main (de8a9b2) will decrease coverage by 0.12%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main   #13250      +/-   ##
==========================================
- Coverage   61.76%   61.64%   -0.12%     
==========================================
  Files         117      117              
  Lines        3452     3452              
  Branches      483      483              
==========================================
- Hits         2132     2128       -4     
- Misses       1236     1241       +5     
+ Partials       84       83       -1     
Flag Coverage Δ *Carryforward flag
bridge-ui 94.33% <ø> (ø) Carriedforward from de8a9b2
protocol 52.32% <0.00%> (-0.23%) ⬇️
relayer 65.18% <ø> (ø) Carriedforward from de8a9b2
ui 100.00% <ø> (ø) Carriedforward from de8a9b2

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...es/protocol/contracts/test/erc20/FreeMintERC20.sol 0.00% <0.00%> (ø)
...ocol/contracts/test/erc20/MayFailFreeMintERC20.sol 0.00% <0.00%> (ø)
...es/protocol/contracts/thirdparty/LibMerkleTrie.sol 83.13% <0.00%> (-7.23%) ⬇️
...ges/protocol/contracts/libs/LibAnchorSignature.sol 100.00% <0.00%> (+10.52%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jscriptcoder jscriptcoder added this pull request to the merge queue Mar 3, 2023
Merged via the queue into main with commit 5920b7e Mar 3, 2023
@jscriptcoder jscriptcoder deleted the fix-protocol_wrong-minting-calculation branch March 3, 2023 15:55
@gitpoap-bot
Copy link

gitpoap-bot bot commented Mar 3, 2023

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2023 Taiko Contributor:

GitPOAP: 2023 Taiko Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

@github-actions github-actions bot mentioned this pull request Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants