Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bridge-ui): add custom ERC20 tokens support #13170

Merged
merged 25 commits into from
Feb 23, 2023
Merged

feat(bridge-ui): add custom ERC20 tokens support #13170

merged 25 commits into from
Feb 23, 2023

Conversation

shadab-taiko
Copy link
Contributor

@shadab-taiko shadab-taiko commented Feb 16, 2023

Builds on top of #13153
Makes more required changes (majorly replacing signal with msgHash everywhere).
Adds functionality to enable user to paste custom ERC20 address.

Addresses #12960 and #12977

@codecov
Copy link

codecov bot commented Feb 16, 2023

Codecov Report

Merging #13170 (87c1e0b) into main (f39e65d) will increase coverage by 1.26%.
The diff coverage is 86.66%.

@@            Coverage Diff             @@
##             main   #13170      +/-   ##
==========================================
+ Coverage   60.11%   61.37%   +1.26%     
==========================================
  Files         115      115              
  Lines        3450     3397      -53     
  Branches      468      439      -29     
==========================================
+ Hits         2074     2085      +11     
+ Misses       1289     1228      -61     
+ Partials       87       84       -3     
Flag Coverage Δ *Carryforward flag
bridge-ui 93.54% <86.66%> (+0.93%) ⬆️
protocol 52.70% <ø> (+1.69%) ⬆️ Carriedforward from c1dede3
relayer 65.15% <ø> (ø) Carriedforward from c1dede3
ui 100.00% <ø> (ø) Carriedforward from c1dede3

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
packages/bridge-ui/src/constants/abi/Bridge.ts 100.00% <ø> (ø)
packages/bridge-ui/src/constants/abi/TokenVault.ts 100.00% <ø> (ø)
packages/bridge-ui/src/eth/bridge.ts 92.59% <ø> (ø)
packages/bridge-ui/src/proof/service.ts 100.00% <ø> (ø)
packages/bridge-ui/src/erc20/bridge.ts 91.93% <75.00%> (-1.17%) ⬇️
packages/bridge-ui/src/storage/service.ts 98.24% <83.33%> (-1.76%) ⬇️
packages/bridge-ui/src/domain/chain.ts 85.29% <86.66%> (+19.66%) ⬆️
packages/bridge-ui/src/domain/token.ts 84.61% <100.00%> (+2.79%) ⬆️
...ges/protocol/contracts/libs/LibAnchorSignature.sol 89.47% <0.00%> (-10.53%) ⬇️
...ages/bridge-ui/src/utils/recommendProcessingFee.ts 93.54% <0.00%> (-6.46%) ⬇️
... and 6 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

packages/bridge-ui/README.md Show resolved Hide resolved
packages/bridge-ui/src/domain/token.ts Outdated Show resolved Hide resolved
packages/bridge-ui/src/storage/customTokenService.ts Outdated Show resolved Hide resolved
packages/bridge-ui/src/storage/customTokenService.ts Outdated Show resolved Hide resolved
@dantaik dantaik enabled auto-merge February 23, 2023 02:54
@dantaik dantaik requested review from dantaik and removed request for dionysuzx February 23, 2023 02:54
@dantaik dantaik disabled auto-merge February 23, 2023 02:55
@dantaik dantaik enabled auto-merge February 23, 2023 02:55
@dantaik dantaik changed the title feat(bridge-ui): add custom ERC20 token support feat(bridge-ui): add custom ERC20 tokens support Feb 23, 2023
@dantaik dantaik requested review from dantaik and removed request for dionysuzx and RogerLamTd February 23, 2023 03:21
@dantaik dantaik added this pull request to the merge queue Feb 23, 2023
Merged via the queue into main with commit 227d8de Feb 23, 2023
@dantaik dantaik deleted the custom-erc20 branch February 23, 2023 03:44
@github-actions github-actions bot mentioned this pull request Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants