Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(protocol): revert Bridge receive() checks #13128

Merged
merged 2 commits into from
Feb 10, 2023
Merged

feat(protocol): revert Bridge receive() checks #13128

merged 2 commits into from
Feb 10, 2023

Conversation

dantaik
Copy link
Contributor

@dantaik dantaik commented Feb 10, 2023

Some integration tests fails after the recent change, so I'm reverting the change and will investigate later.

@dantaik dantaik changed the title Revert "feat(protocol): restrict receive()'s msg.sender to vaults (#1… feat(protocol): revert Bridge receive() checks Feb 10, 2023
@dantaik dantaik marked this pull request as ready for review February 10, 2023 03:40
davidtaikocha
davidtaikocha previously approved these changes Feb 10, 2023
@codecov
Copy link

codecov bot commented Feb 10, 2023

Codecov Report

Merging #13128 (cbc0da6) into main (ff99f50) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main   #13128   +/-   ##
=======================================
  Coverage   62.85%   62.85%           
=======================================
  Files         113      113           
  Lines        3209     3209           
  Branches      434      434           
=======================================
  Hits         2017     2017           
  Misses       1116     1116           
  Partials       76       76           
Flag Coverage Δ *Carryforward flag
bridge-ui 92.61% <ø> (ø) Carriedforward from ff99f50
protocol 53.34% <100.00%> (ø)
relayer 69.15% <ø> (ø) Carriedforward from ff99f50
ui 100.00% <ø> (ø) Carriedforward from ff99f50

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
packages/protocol/contracts/bridge/Bridge.sol 46.66% <ø> (ø)
...ackages/protocol/contracts/bridge/BridgedERC20.sol 95.65% <ø> (ø)
packages/protocol/contracts/bridge/TokenVault.sol 50.57% <ø> (ø)
...protocol/contracts/bridge/libs/LibBridgeStatus.sol 60.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dantaik dantaik merged commit 675611d into main Feb 10, 2023
@dantaik dantaik deleted the undo_change branch February 10, 2023 03:58
@github-actions github-actions bot mentioned this pull request Feb 10, 2023
dantaik added a commit that referenced this pull request Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants