Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(protocol): add more protocol/tokenomics tests #12988

Merged
merged 66 commits into from
Feb 6, 2023
Merged

feat(protocol): add more protocol/tokenomics tests #12988

merged 66 commits into from
Feb 6, 2023

Conversation

cyberhorsey
Copy link
Contributor

@cyberhorsey cyberhorsey commented Jan 19, 2023

This PR encompasses the following intended functionality:

  • Reusable proposer and provers for easier writing of tests.
  • An end-to-end commit -> propose -> prove -> verify flow in Typescript for the tests, running a "simulation" of the real world.
  • Initial tests for blockFee and proofReward, which ascertain that with the network running and blocks being committed, proposed, proved, and verified, that rewards are issued, deposits are taken, and deposits are returned.
  • Sets us up as able to write additional tests for Tokenomics easier.

closes #13043

@cyberhorsey cyberhorsey marked this pull request as ready for review January 24, 2023 08:11
@cyberhorsey cyberhorsey requested review from dantaik and dong77 February 2, 2023 18:37
@dantaik dantaik enabled auto-merge (squash) February 3, 2023 07:18
@dantaik dantaik requested review from dantaik and removed request for dong77 February 5, 2023 07:17
Copy link
Member

@davidtaikocha davidtaikocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test cases LTGM, for some improvements like changing to use two hardhat nodes to run these tests, i think we can do it in another PR.

@dantaik dantaik removed the request for review from RogerLamTd February 6, 2023 08:35
@dantaik dantaik disabled auto-merge February 6, 2023 08:36
@dantaik dantaik requested review from RogerLamTd and removed request for RogerLamTd February 6, 2023 08:37
@dantaik dantaik merged commit 3a7523f into main Feb 6, 2023
@dantaik dantaik deleted the prover_tests branch February 6, 2023 08:39
@github-actions github-actions bot mentioned this pull request Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@cyberhorsey I run tokenonmics tests but found there are errors:
5 participants