-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(protocol): add special logics for alpha-2 testnet #12987
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dantaik
requested review from
alexshliu,
cyberhorsey,
dionysuzx and
davidtaikocha
January 19, 2023 04:13
Codecov Report
@@ Coverage Diff @@
## main #12987 +/- ##
==========================================
- Coverage 66.32% 66.15% -0.18%
==========================================
Files 113 112 -1
Lines 3050 3052 +2
Branches 357 363 +6
==========================================
- Hits 2023 2019 -4
- Misses 951 957 +6
Partials 76 76
*This pull request uses carry forward flags. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
davidtaikocha
approved these changes
Jan 19, 2023
dionysuzx
approved these changes
Jan 20, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For alpha-2 testnet, the network only allows an special address to propose but anyone to prove. This is the first step of testing the tokenomics. In this PR, a special prover can skip ZKP verification if the ZKP is empty which is to handle unexpected ZKP circuit bugs.
I also rebranded TkoToken as a Taiko USD stablecoin token, so we don't have to create a marketplace for it and can incentivize people with 1tkUSD == 1 USDT/USDC.
This PR shall be reverted once alpha-2 is shutdown.