Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tests): cleanup tests to prepare for tokenomics testing #11316

Merged
merged 49 commits into from
Jan 14, 2023
Merged

Conversation

cyberhorsey
Copy link
Contributor

@cyberhorsey cyberhorsey commented Jan 6, 2023

Noticed for Tokenomcis testing I will need to reuse a lit of functionality. Started to cleanup TaikoL1 tests but also moved on to Bridge as they seemed the messiest so far.

Decided to separate integration tests into their own files.

Did a bunch of scaffolding for tokenomics testing, like creating a proposer class we can reuse, and started on proving but it isn't finished yet.

Added a new config option for whether TaikoL2 should check public inputs, so I can call anchor successfully.

@codecov
Copy link

codecov bot commented Jan 6, 2023

Codecov Report

Merging #11316 (34ff709) into main (9837fa3) will decrease coverage by 1.37%.
The diff coverage is 34.00%.

@@            Coverage Diff             @@
##             main   #11316      +/-   ##
==========================================
- Coverage   67.79%   66.41%   -1.38%     
==========================================
  Files         109      113       +4     
  Lines        2937     3034      +97     
  Branches      354      356       +2     
==========================================
+ Hits         1991     2015      +24     
- Misses        869      943      +74     
+ Partials       77       76       -1     
Flag Coverage Δ *Carryforward flag
bridge-ui 95.05% <ø> (ø) Carriedforward from b1358dd
protocol 59.23% <34.00%> (-2.11%) ⬇️
relayer 68.92% <ø> (-0.18%) ⬇️
ui 100.00% <ø> (ø) Carriedforward from b1358dd

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
packages/protocol/contracts/L1/libs/LibUtils.sol 27.27% <ø> (ø)
...ckages/protocol/contracts/libs/LibSharedConfig.sol 0.00% <ø> (ø)
.../contracts/test/L1/TestTaikoL1EnableTokenomics.sol 0.00% <0.00%> (ø)
...ackages/protocol/contracts/test/L1/TestTaikoL2.sol 0.00% <0.00%> (ø)
...rotocol/contracts/test/thirdparty/TestTKOToken.sol 0.00% <0.00%> (ø)
packages/protocol/contracts/L2/TaikoL2.sol 52.94% <50.00%> (-0.26%) ⬇️
...ackages/protocol/contracts/test/L1/TestTaikoL1.sol 87.50% <100.00%> (+0.40%) ⬆️
...cts/test/L1/TestTaikoL2EnablePublicInputsCheck.sol 100.00% <100.00%> (ø)
...es/protocol/contracts/thirdparty/LibMerkleTrie.sol 83.13% <0.00%> (-7.23%) ⬇️
packages/relayer/http/server.go 93.15% <0.00%> (-2.74%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

…utils to regular utils folders, reusabel deploy functions for taikol1 and taikol2
@vercel
Copy link

vercel bot commented Jan 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
website 🔄 Building (Inspect) Jan 6, 2023 at 8:34PM (UTC)

packages/protocol/test/L1/TaikoL1.integration.test.ts Outdated Show resolved Hide resolved
packages/protocol/test/L1/TaikoL1.integration.test.ts Outdated Show resolved Hide resolved
packages/protocol/test/L1/TaikoL1.integration.test.ts Outdated Show resolved Hide resolved
packages/protocol/test/L1/TaikoL1.integration.test.ts Outdated Show resolved Hide resolved
packages/protocol/test/utils/propose.ts Show resolved Hide resolved
packages/protocol/test/L1/TaikoL1.integration.test.ts Outdated Show resolved Hide resolved
packages/protocol/test/L1/TaikoL1.integration.test.ts Outdated Show resolved Hide resolved
packages/protocol/test/test_tokenomics.sh Outdated Show resolved Hide resolved
@cyberhorsey cyberhorsey marked this pull request as draft January 7, 2023 20:09
Co-authored-by: dave | d1onys1us <13951458+d1onys1us@users.noreply.github.com>
@dantaik
Copy link
Contributor

dantaik commented Jan 12, 2023

@cyberhorsey is this ready for review? (just in case you forgot to change the status)

@dantaik dantaik enabled auto-merge (squash) January 14, 2023 03:02
@dantaik dantaik merged commit d63fae3 into main Jan 14, 2023
@dantaik dantaik deleted the test_cleanup branch January 14, 2023 03:10
@github-actions github-actions bot mentioned this pull request Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants