Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(txpool): basefee requires mintip to not be nil. #297

Merged
merged 1 commit into from
Aug 8, 2024
Merged

fix(txpool): basefee requires mintip to not be nil. #297

merged 1 commit into from
Aug 8, 2024

Conversation

johntaiko
Copy link

@johntaiko johntaiko commented Aug 8, 2024 •
edited
Loading

taiko-geth/core/txpool/legacypool/legacypool.go

Line 550 in 882a6cd

if minTipBig != nil && !pool.locals.contains(addr) {

The BaseFee is only effective if MinTip is not nil.

@johntaiko johntaiko enabled auto-merge (squash) August 8, 2024 06:34
@johntaiko johntaiko merged commit 6315fd4 into taiko Aug 8, 2024
3 checks passed
@johntaiko johntaiko deleted the fix/tx_pool_filter branch August 8, 2024 06:40
@taiko-kitty taiko-kitty mentioned this pull request Aug 8, 2024
Merged
lwedge99 pushed a commit to sentioxyz/taiko-geth that referenced this pull request Sep 23, 2024
@johntaiko @lwedge99
fix(txpool): basefee requires mintip to not be nil. (taikoxyz#297)
37cde02
@taiko-kitty taiko-kitty mentioned this pull request Sep 26, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mask-pp mask-pp mask-pp approved these changes

@YoGhurt111 YoGhurt111 Awaiting requested review from YoGhurt111

@davidtaikocha davidtaikocha Awaiting requested review from davidtaikocha

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johntaiko @mask-pp