Skip to content

Commit

Permalink
feat: merge 1.14.10
Browse files Browse the repository at this point in the history
  • Loading branch information
davidtaikocha committed Sep 29, 2024
1 parent d11d7ba commit 25e1b1d
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 9 deletions.
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

[![CI](https://github.com/taikoxyz/taiko-geth/actions/workflows/ci.yml/badge.svg)](https://github.com/taikoxyz/taiko-geth/actions/workflows/ci.yml)

The codebase is based on [go-ethereum v1.13.15](https://github.com/ethereum/go-ethereum/releases/tag/v1.13.15).
The codebase is based on [go-ethereum v1.14.10](https://github.com/ethereum/go-ethereum/releases/tag/v1.14.10).

## Tracing changes

Expand Down Expand Up @@ -116,7 +116,7 @@ useful on the testnet too.

Specifying the `--holesky` flag, however, will reconfigure your `geth` instance a bit:

* Instead of connecting to the main Ethereum network, the client will connect to the Holesky
* Instead of connecting to the main Ethereum network, the client will connect to the Holesky
test network, which uses different P2P bootnodes, different network IDs and genesis
states.
* Instead of using the default data directory (`~/.ethereum` on Linux for example), `geth`
Expand Down
2 changes: 1 addition & 1 deletion eth/catalyst/api.go
Original file line number Diff line number Diff line change
Expand Up @@ -470,7 +470,7 @@ func (api *ConsensusAPI) forkchoiceUpdated(update engine.ForkchoiceStateV1, payl
Version: payloadVersion,
}
id := args.Id()
payload, err := api.eth.Miner().BuildPayload(args)
payload, err := api.eth.Miner().BuildPayload(args, false)
if err != nil {
log.Error("Failed to build payload", "err", err)
return valid(nil), engine.InvalidPayloadAttributes.With(err)
Expand Down
8 changes: 4 additions & 4 deletions miner/taiko_payload_building_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ func TestSetFullBlock_AvoidPanic(t *testing.T) {
Random: common.Hash{},
FeeRecipient: recipient,
}
payload, err := w.buildPayload(args)
payload, err := w.buildPayload(args, false)
if err != nil {
t.Fatalf("Failed to build payload %v", err)
}
Expand Down Expand Up @@ -66,7 +66,7 @@ func TestAfterSetFullBlock_Panic_DoneChannelNotSent(t *testing.T) {
Random: common.Hash{},
FeeRecipient: recipient,
}
payload, err := w.buildPayload(args)
payload, err := w.buildPayload(args, false)
if err != nil {
t.Fatalf("Failed to build payload %v", err)
}
Expand Down Expand Up @@ -94,7 +94,7 @@ func TestAfterSetFullBlockAvoidPanicDoneChannelSent(t *testing.T) {
Random: common.Hash{},
FeeRecipient: recipient,
}
payload, err := w.buildPayload(args)
payload, err := w.buildPayload(args, false)
if err != nil {
t.Fatalf("Failed to build payload %v", err)
}
Expand All @@ -121,7 +121,7 @@ func TestSetFullBlock(t *testing.T) {
Random: common.Hash{},
FeeRecipient: recipient,
}
payload, err := w.buildPayload(args)
payload, err := w.buildPayload(args, false)
if err != nil {
t.Fatalf("Failed to build payload %v", err)
}
Expand Down
4 changes: 2 additions & 2 deletions miner/taiko_worker.go
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ func (w *Miner) buildTransactionsLists(
baseFeePerGas: baseFee,
}

env, err := w.prepareWork(params)
env, err := w.prepareWork(params, false)
if err != nil {
return nil, err
}
Expand Down Expand Up @@ -161,7 +161,7 @@ func (w *Miner) sealBlockWith(
// Set extraData
w.SetExtra(blkMeta.ExtraData)

env, err := w.prepareWork(params)
env, err := w.prepareWork(params, false)
if err != nil {
return nil, err
}
Expand Down

0 comments on commit 25e1b1d

Please sign in to comment.