Skip to content
This repository has been archived by the owner on May 11, 2024. It is now read-only.

feat(config): simplify config loading #507

Merged
merged 11 commits into from
Jan 21, 2024
Merged

feat(config): simplify config loading #507

merged 11 commits into from
Jan 21, 2024

Conversation

mask-pp
Copy link
Contributor

@mask-pp mask-pp commented Jan 16, 2024

No description provided.

Copy link

codecov bot commented Jan 16, 2024

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (d7a1932) 56.76% compared to head (2a99810) 56.50%.
Report is 1 commits behind head on main.

❗ Current head 2a99810 differs from pull request most recent head 3b81fb3. Consider uploading reports for the commit 3b81fb3 to get more accurate results

Files Patch % Lines
proposer/proposer.go 76.92% 3 Missing and 3 partials ⚠️
driver/driver.go 66.66% 0 Missing and 2 partials ⚠️
pkg/rpc/client.go 77.77% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #507      +/-   ##
==========================================
- Coverage   56.76%   56.50%   -0.26%     
==========================================
  Files          44       44              
  Lines        5634     5578      -56     
==========================================
- Hits         3198     3152      -46     
+ Misses       2111     2103       -8     
+ Partials      325      323       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mask-pp mask-pp marked this pull request as draft January 16, 2024 16:02
@mask-pp mask-pp marked this pull request as ready for review January 17, 2024 03:09
pkg/rpc/client.go Outdated Show resolved Hide resolved
proposer/config.go Outdated Show resolved Hide resolved
driver/driver.go Outdated Show resolved Hide resolved
@davidtaikocha davidtaikocha enabled auto-merge (squash) January 21, 2024 14:31
@davidtaikocha davidtaikocha merged commit 5f9d843 into main Jan 21, 2024
4 checks passed
@davidtaikocha davidtaikocha deleted the fix/config branch January 21, 2024 14:36
davidtaikocha added a commit that referenced this pull request Jan 21, 2024
Co-authored-by: David <david@taiko.xyz>
Co-authored-by: RogerLamTd <bob.rogerbob1@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants