This repository has been archived by the owner on May 11, 2024. It is now read-only.
feat(rpc): fix a bug and update logic #501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #501 +/- ##
==========================================
+ Coverage 58.09% 58.10% +0.01%
==========================================
Files 44 44
Lines 5543 5540 -3
==========================================
- Hits 3220 3219 -1
+ Misses 2001 1999 -2
Partials 322 322 ☔ View full report in Codecov by Sentry. |
mask-pp
changed the title
davidtaikocha
changed the title
davidtaikocha
approved these changes
Jan 14, 2024
davidtaikocha
added a commit
that referenced
this pull request
Jan 14, 2024
Co-authored-by: David <david@taiko.xyz>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix list:
opts != nil && opts.Context == nil, opts will be overridden directly by a new one.ctxis nil, will appear panic.l1HeadSubinClose()function.