This repository has been archived by the owner on May 11, 2024. It is now read-only.
fix(prover): only store signed block after successfully sending http request #489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #489 +/- ##
==========================================
+ Coverage 58.11% 58.18% +0.07%
==========================================
Files 44 44
Lines 5520 5520
==========================================
+ Hits 3208 3212 +4
+ Misses 1993 1990 -3
+ Partials 319 318 -1 ☔ View full report in Codecov by Sentry. |
davidtaikocha
approved these changes
Jan 7, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, the block is saved to the local levelsdb before being sent to the central health check server. In case that request fails, it will not re-attempt it when iterating through blocks later. We should only save it after successfully sending.