Skip to content
This repository has been archived by the owner on May 11, 2024. It is now read-only.

feat(proposer): optimze log #464

Merged
merged 4 commits into from
Dec 7, 2023

Conversation

bnovil
Copy link
Contributor

@bnovil bnovil commented Dec 6, 2023

Currently, when L2 execution engine is syncing, proposer logs are like:

taiko_client_proposer_1  | INFO [12-05|10:31:57.800] L2 execution engine is syncing           progress="&{SyncProgress:0xc0000d07e0 CurrentBlockID:+1356428 HighestBlockID:+1453513}"
taiko_client_proposer_1  | INFO [12-05|10:32:10.073] L2 execution engine is syncing           progress="&{SyncProgress:0xc0000d0900 CurrentBlockID:+1356428 HighestBlockID:+1453513}"
taiko_client_proposer_1  | INFO [12-05|10:32:22.345] L2 execution engine is syncing           progress="&{SyncProgress:0xc0000d03f0 CurrentBlockID:+1356428 HighestBlockID:+1453517}"
taiko_client_proposer_1  | INFO [12-05|10:32:34.619] L2 execution engine is syncing           progress="&{SyncProgress:0xc00036b710 CurrentBlockID:+1356428 HighestBlockID:+1453520}"

The progress field don't have useful information. This PR enhance the log to provide more details.
The log will be like:

taiko_client_proposer_1  | INFO [12-06|02:36:33.600] L2 execution engine is syncing           CurrentBlockID=1,356,428 HighestBlockID=1,464,417 progress="&{StartingBlock:1447613 CurrentBlock:1452990 HighestBlock:1463134 PulledStates:0 KnownStates:0 SyncedAccounts:0 SyncedAccountBytes:0 SyncedBytecodes:0 SyncedBytecodeBytes:0 SyncedStorage:0 SyncedStorageBytes:0 HealedTrienodes:0 HealedTrienodeBytes:0 HealedBytecodes:0 HealedBytecodeBytes:0 HealingTrienodes:0 HealingBytecode:0}"
taiko_client_proposer_1  | INFO [12-06|02:36:45.857] L2 execution engine is syncing           CurrentBlockID=1,356,428 HighestBlockID=1,464,418 progress="&{StartingBlock:1447613 CurrentBlock:1453344 HighestBlock:1463134 PulledStates:0 KnownStates:0 SyncedAccounts:0 SyncedAccountBytes:0 SyncedBytecodes:0 SyncedBytecodeBytes:0 SyncedStorage:0 SyncedStorageBytes:0 HealedTrienodes:0 HealedTrienodeBytes:0 HealedBytecodes:0 HealedBytecodeBytes:0 HealingTrienodes:0 HealingBytecode:0}"
taiko_client_proposer_1  | INFO [12-06|02:36:58.110] L2 execution engine is syncing           CurrentBlockID=1,356,428 HighestBlockID=1,464,420 progress="&{StartingBlock:1447613 CurrentBlock:1453702 HighestBlock:1463134 PulledStates:0 KnownStates:0 SyncedAccounts:0 SyncedAccountBytes:0 SyncedBytecodes:0 SyncedBytecodeBytes:0 SyncedStorage:0 SyncedStorageBytes:0 HealedTrienodes:0 HealedTrienodeBytes:0 HealedBytecodes:0 HealedBytecodeBytes:0 HealingTrienodes:0 HealingBytecode:0}"

Copy link

codecov bot commented Dec 7, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (eb5bc7a) 60.56% compared to head (bc03fa2) 60.55%.

Files Patch % Lines
pkg/rpc/methods.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #464      +/-   ##
==========================================
- Coverage   60.56%   60.55%   -0.02%     
==========================================
  Files          45       45              
  Lines        5472     5473       +1     
==========================================
  Hits         3314     3314              
- Misses       1826     1827       +1     
  Partials      332      332              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davidtaikocha davidtaikocha enabled auto-merge (squash) December 7, 2023 02:43
@davidtaikocha
Copy link
Member

Merged, thanks for the contribution! :)

@davidtaikocha davidtaikocha merged commit c7e899d into taikoxyz:main Dec 7, 2023
4 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants