Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

binstall install is broken #14

Closed
CAD97 opened this issue Jul 26, 2022 · 0 comments · Fixed by #16
Closed

binstall install is broken #14

CAD97 opened this issue Jul 26, 2022 · 0 comments · Fixed by #16
Labels
bug Something isn't working

Comments

@CAD97
Copy link
Contributor

CAD97 commented Jul 26, 2022

https://github.com/CAD97/tracing-filter/runs/7512221824?check_suite_focus=true

cargo binstall does not have a --version flag to print the version, so trying to print its version fails.

install-action/main.sh

Lines 349 to 353 in 7e5692d

info "${tool} installed at $(type -P "${bin}")"
case "${bin}" in
cargo-*) x cargo "${tool#cargo-}" --version ;;
*) x "${tool}" --version ;;
esac

I think that switch just needs a cargo-binstall) x cargo binstall --help | head 1 case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants