From 6e8d2ca5c5b83bf37c4acc5fb18a9f56de2fcdc2 Mon Sep 17 00:00:00 2001 From: Yi Xu Date: Mon, 24 Oct 2022 15:15:27 +0800 Subject: [PATCH 1/2] [vulkan] [bug] Stop using the buffer device address feature on macOS --- taichi/rhi/vulkan/vulkan_device_creator.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/taichi/rhi/vulkan/vulkan_device_creator.cpp b/taichi/rhi/vulkan/vulkan_device_creator.cpp index 6f807260ea825..a430638de2d9d 100644 --- a/taichi/rhi/vulkan/vulkan_device_creator.cpp +++ b/taichi/rhi/vulkan/vulkan_device_creator.cpp @@ -735,7 +735,10 @@ void VulkanDeviceCreator::create_logical_device(bool manual_create) { if (CHECK_VERSION(1, 3) || buffer_device_address_feature.bufferDeviceAddress) { if (device_supported_features.shaderInt64) { +// Temporarily disable it on macOS: https://github.com/taichi-dev/taichi/issues/6295 +#if !defined(__APPLE__) caps.set(DeviceCapability::spirv_has_physical_storage_buffer, true); +#endif } } *pNextEnd = &buffer_device_address_feature; From 9dfda85ab6685344440d989b82cd8e3a9567b624 Mon Sep 17 00:00:00 2001 From: "pre-commit-ci[bot]" <66853113+pre-commit-ci[bot]@users.noreply.github.com> Date: Mon, 24 Oct 2022 07:17:35 +0000 Subject: [PATCH 2/2] [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --- taichi/rhi/vulkan/vulkan_device_creator.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/taichi/rhi/vulkan/vulkan_device_creator.cpp b/taichi/rhi/vulkan/vulkan_device_creator.cpp index a430638de2d9d..1d6d948abd4e4 100644 --- a/taichi/rhi/vulkan/vulkan_device_creator.cpp +++ b/taichi/rhi/vulkan/vulkan_device_creator.cpp @@ -735,7 +735,8 @@ void VulkanDeviceCreator::create_logical_device(bool manual_create) { if (CHECK_VERSION(1, 3) || buffer_device_address_feature.bufferDeviceAddress) { if (device_supported_features.shaderInt64) { -// Temporarily disable it on macOS: https://github.com/taichi-dev/taichi/issues/6295 +// Temporarily disable it on macOS: +// https://github.com/taichi-dev/taichi/issues/6295 #if !defined(__APPLE__) caps.set(DeviceCapability::spirv_has_physical_storage_buffer, true); #endif