Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate ndarray dtype in C++ wrapper. #7276

Open
ailzhang opened this issue Feb 1, 2023 · 2 comments
Open

Validate ndarray dtype in C++ wrapper. #7276

ailzhang opened this issue Feb 1, 2023 · 2 comments
Assignees
Labels

Comments

@ailzhang
Copy link
Contributor

ailzhang commented Feb 1, 2023

In deployment scenarios, we may accidentally pass in an ndarray with wrong dtype compared to the one required by the compiled kernel, we should throw proper error to users when it happens.

@ailzhang
Copy link
Contributor Author

ailzhang commented Feb 1, 2023

Also we don't check number of args matches compiled kernel so it might segfault without any message, maybe also good to validate that and throw a proper error :D

@lin-hitonami lin-hitonami moved this from Untriaged to Todo in Taichi Lang Feb 3, 2023
@ailzhang ailzhang added this to the v1.5.0 milestone Feb 10, 2023
@PENGUINLIONG PENGUINLIONG modified the milestones: v1.5.0, v1.6.0 Mar 9, 2023
@feisuzhu feisuzhu modified the milestones: v1.6.0, v1.7.0 May 11, 2023
@lgyStoic
Copy link
Contributor

lgyStoic commented Jul 18, 2023

right! I encounter this issue when I using u8 ndarray as passed value in JIT which parameter is u32 ndarray, taichi JIT convert the type automaticly. But in AOT mode, I pass u8 ndarray to module, the whole algorithm goes wrong ! I think it's neccessory adding the type checker for taichi AOT

@jim19930609 jim19930609 removed this from the v1.7.0 milestone Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Todo
Development

No branches or pull requests

5 participants