-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't hash the pointer to the real function when generating the offline cache key #6929
Comments
lin-hitonami
changed the title
Don't use the pointer to the real function when generating the offline cache key
Don't hash the pointer to the real function when generating the offline cache key
Dec 20, 2022
FYI, @lin-hitonami taichi/taichi/analysis/gen_offline_cache_key.cpp Lines 509 to 519 in 9cbc59a
taichi/taichi/analysis/gen_offline_cache_key.cpp Lines 433 to 440 in 9cbc59a
|
However, the algorithm that generates the AST key for the real function is indeed wrong. See #6877. I will redesign it. |
Okay, I missed that part. |
Repository owner
moved this from Untriaged
to Done
in Taichi Lang
Dec 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
When we get the offline cache key, we use the value of
Function *
as the key of the real function. However, this changes when we reset Taichi. We should use the hash key of the IR of the real function instead.taichi/taichi/analysis/gen_offline_cache_key.cpp
Line 243 in 9cbc59a
The text was updated successfully, but these errors were encountered: