Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify dense.bitmasked to bitmasked #663

Closed
k-ye opened this issue Mar 27, 2020 · 2 comments
Closed

Simplify dense.bitmasked to bitmasked #663

k-ye opened this issue Mar 27, 2020 · 2 comments
Assignees
@k-ye
Labels
feature request Suggest an idea on this project

Comments

@k-ye
Copy link
Member

k-ye commented Mar 27, 2020

Concisely describe the proposed feature

Right now, bitmasked is a decorator on dense SNode. We can separate that so that bitmasked becomes its own SNode type. This came up from #661 . @KLozes also did the same thing for pointer in #462.
@k-ye k-ye added the feature request Suggest an idea on this project label Mar 27, 2020
@k-ye k-ye self-assigned this Mar 27, 2020
@yuanming-hu
Copy link
Member

Thanks! I'll fix bitmasked garbage collection and zero filling on CPU/CUDA after this. Then we can ship the brand new bitmasked node with v0.5.9 :-)

@k-ye k-ye mentioned this issue Mar 28, 2020
Merged
@k-ye
Copy link
Member Author

k-ye commented Apr 2, 2020

#676 did this for LLVM backends

@k-ye k-ye closed this as completed Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@k-ye k-ye

Labels
feature request Suggest an idea on this project
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yuanming-hu @k-ye