From f677fb1417d906b2c13d1fa308378c4272c28f19 Mon Sep 17 00:00:00 2001 From: Yi Xu Date: Mon, 24 Oct 2022 16:20:58 +0800 Subject: [PATCH] [vulkan] [bug] Stop using the buffer device address feature on macOS (#6415) See https://github.com/taichi-dev/taichi/issues/6295#issuecomment-1288522905. Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> --- taichi/rhi/vulkan/vulkan_device_creator.cpp | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/taichi/rhi/vulkan/vulkan_device_creator.cpp b/taichi/rhi/vulkan/vulkan_device_creator.cpp index 6f807260ea825..1d6d948abd4e4 100644 --- a/taichi/rhi/vulkan/vulkan_device_creator.cpp +++ b/taichi/rhi/vulkan/vulkan_device_creator.cpp @@ -735,7 +735,11 @@ void VulkanDeviceCreator::create_logical_device(bool manual_create) { if (CHECK_VERSION(1, 3) || buffer_device_address_feature.bufferDeviceAddress) { if (device_supported_features.shaderInt64) { +// Temporarily disable it on macOS: +// https://github.com/taichi-dev/taichi/issues/6295 +#if !defined(__APPLE__) caps.set(DeviceCapability::spirv_has_physical_storage_buffer, true); +#endif } } *pNextEnd = &buffer_device_address_feature;