Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unique Ids contain "too much uniqueness" #112

Open
mattsaxon opened this issue Mar 18, 2022 · 2 comments
Open

Unique Ids contain "too much uniqueness" #112

mattsaxon opened this issue Mar 18, 2022 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@mattsaxon
Copy link
Collaborator

Since the unique IDs contain the serial port name, this means that the system creates duplicate IDs when the serial ports changes.

Since it is unlikely that a house will have 2 alarm systems, this uniqueness is unnecessary IMO and creates issues during debugging or changing of system configuration.

There are a couple of options I can think of;

  1. Remove the serial ports from the unique name (this would be a breaking change)
  2. Add a system name to the config that overrides the serial name (this would not be a breaking change, but would be a bit more complex to code)
@mattsaxon
Copy link
Collaborator Author

mattsaxon commented Mar 18, 2022

This issue was found when fixing issue #17 as I had to reconfigure my system and actually used a remote serial with name "socket://192.168.0.8:23?logging=True".

This creates a set of duplicate IDs and as you can see from how specific a remote name is creates many each time you change IP, port or even debugging info

@mattsaxon mattsaxon added the question Further information is requested label Mar 18, 2022
@tahvane1
Copy link
Owner

Maybe option to config to NOT use serial as unique name?

@mattsaxon mattsaxon assigned mattsaxon and unassigned tahvane1 May 8, 2022
@mattsaxon mattsaxon added enhancement New feature or request and removed question Further information is requested labels May 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants