Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate if XP code can be used for TAHOclaiming #644

Closed
Tracked by #227
jagodarybacka opened this issue Nov 7, 2023 · 1 comment
Closed
Tracked by #227

Investigate if XP code can be used for TAHOclaiming #644

jagodarybacka opened this issue Nov 7, 2023 · 1 comment
Assignees
Milestone

Comments

@jagodarybacka
Copy link
Contributor

No description provided.

@jagodarybacka
Copy link
Contributor Author

Spike results:

The goal of the spike was to decide if we want to change anything about the allowlist mechanism that we are using for XP drops for implementing the TAHO claim feature.

Choosing the mechanism

Projects that need allowlists the most are NFT projects. The outcome of the spike is that most NFT projects are not using merkle trees as a way to verify who is on the allowlist. The most popular solution is to do signature-based allowlisting. As we don't want to change the existing contracts that is a no-go for us and it will be safer to use the same merkle tree code as we used for XP claiming.
More on signature based allowlists: Source 1 Source 2

XP claim mechanism pain points

  • generating XP requires manual work and is quite slow - that won't be the issue for the TAHO claim because the allowlist will be generated only once
  • storing XP and fetching XP claim files - XP drop source files are stored inside the dapp repository which requires using our own infra to keep quite a lot of JSON files up and running. We may want to use external source to store TAHO claim files so we can decentralize the claim source data more.

Things that are left to do are:

  • decide on where do we want to store TAHO claim source files
  • abstract the XP code to be reusable for TAHO claims
  • add unit tests for the claiming code
  • add e2e tests for claiming UI
  • automate the generation of XP claim files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant