Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Condition: 'All'" should not be a default option #63

Open
masterT opened this issue Sep 26, 2016 · 3 comments
Open

"Condition: 'All'" should not be a default option #63

masterT opened this issue Sep 26, 2016 · 3 comments
Milestone

Comments

@masterT
Copy link
Collaborator

masterT commented Sep 26, 2016

As seen in PR #62 by @oldstreams.

@masterT
Copy link
Collaborator Author

masterT commented Sep 26, 2016

ItemSearch 📖 Documentation

Required: No

The Condition parameter filters offers by condition type. By default, Condition equals New. When the Availability parameter is set to Available, the Condition parameter cannot be set to New.

When Condition is set to All, ItemSearch returns one offer per condition.

Condition can be used with every index, except All and Blended.

Type: String

Default: New

Valid values: New | Used | Collectible | Refurbished | All

ItemLookup 📖 Documentation

Required: No

Specifies an item's condition. If Condition is set to "All", a separate set of responses is returned for each valid value of Condition. The default value is "New" (not "All"). So, if your request does not return results, consider setting the value to "All". When the value is "New", the ItemLookup availability parameter cannot be set to "Available". Amazon only sells items that are "New".

Type: String

Default: New

Valid Values: Used | Collectible | Refurbished | All

@masterT
Copy link
Collaborator Author

masterT commented Sep 27, 2016

@oldstreams I think that if you want to use the default behaviour, you can simply pass the default AWS value which is New for both operations.

@aengl
Copy link

aengl commented Sep 6, 2017

I tested this for both All and New and it does not return the same result in all cases, compared to not specifying Condition at all. Workaround is to actually set Condition to an empty string, but I'd prefer this to not be specified by default since it's not required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants