Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why not use https in the url example with passwords? #14

Closed
sirkkalap opened this issue Oct 21, 2017 · 2 comments
Closed

Why not use https in the url example with passwords? #14

sirkkalap opened this issue Oct 21, 2017 · 2 comments
Labels
depends-on-obs-weboscket Needs support by obs-websocket first wontfix

Comments

@sirkkalap
Copy link

Hi,

Would it make sense to use HTTPS when passing passwords in the url?

-Pete

@sirkkalap
Copy link
Author

And it seems that the HTTPS is not ok there.

Maybe a warning then?

Password will be blindly broadcast in plain text, is it not?

@t2t2
Copy link
Owner

t2t2 commented Oct 21, 2017

Since obs-websocket doesn't support https/wss (obsproject/obs-websocket#26), loading the site over https will block the ws connection in most browsers since it's mixed content. Hence the warning when it is being loaded over https

I don't think the hash part of the URL gets sent to the server (when loading the page) so I think that part is fine, ofc MITM threat still is gonna exist. The connecting itself doesn't broadcast the password but a one-time hash.

Probably worth extra warning somewhere in UI about password security 🤷‍♂️

@t2t2 t2t2 added the wontfix label May 31, 2019
@t2t2 t2t2 closed this as completed May 31, 2019
@t2t2 t2t2 added the depends-on-obs-weboscket Needs support by obs-websocket first label May 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
depends-on-obs-weboscket Needs support by obs-websocket first wontfix
Projects
None yet
Development

No branches or pull requests

2 participants