Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

session.destroy(error) should throw if there's no error event handler #22

Closed
szmarczak opened this issue Aug 5, 2019 · 0 comments · Fixed by #21
Closed

session.destroy(error) should throw if there's no error event handler #22

szmarczak opened this issue Aug 5, 2019 · 0 comments · Fixed by #21
Assignees
Labels
bug Something isn't working low priority
Milestone

Comments

@szmarczak
Copy link
Owner

This is because the Agent class attaches its own error handler.

It should check if someone has attached an additional handler. If they did, don't throw. If they didn't, throw.

session.on('error', error => {
	...

	if (listenerCount === 0) {
		throw error;
	}
});
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working low priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant