Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding to homebrew, but found a bug #76

Closed
zbeekman opened this issue Aug 14, 2015 · 5 comments
Closed

Adding to homebrew, but found a bug #76

zbeekman opened this issue Aug 14, 2015 · 5 comments

Comments

@zbeekman
Copy link
Contributor

Hi Stefano,
I'm trying to add FoBiS.py to Homebrew. However, I found what appears to be a bug:

FoBiS.py build -compiler Custom -fc gfortran
Traceback (most recent call last):
  File "/usr/local/bin/FoBiS.py", line 21, in <module>
    main()
  File "/usr/local/lib/python2.7/site-packages/fobis/fobis.py", line 30, in main
    __config__.run_fobis()
  File "/usr/local/lib/python2.7/site-packages/fobis/config.py", line 663, in run_fobis
    self._build()
  File "/usr/local/lib/python2.7/site-packages/fobis/config.py", line 543, in _build
    builder = Builder(cliargs=self.cliargs, print_n=self._print_b, print_w=self._print_r)
  File "/usr/local/lib/python2.7/site-packages/fobis/Builder.py", line 102, in __init__
    self.compiler = Compiler(cliargs=cliargs, print_w=self.print_w)
  File "/usr/local/lib/python2.7/site-packages/fobis/Compiler.py", line 108, in __init__
    self._set_cflags()
  File "/usr/local/lib/python2.7/site-packages/fobis/Compiler.py", line 177, in _set_cflags
    if self.preproc is not None:
AttributeError: 'Compiler' object has no attribute 'preproc'

But the source files build with gfortran, without problem and require no preprocessing.

@zbeekman
Copy link
Contributor Author

hmmm I guess many of the flags are non-optional when using "custom" compiler. I wonder if a better error message would be possible in this case, and improved documentation.

@szaghi
Copy link
Owner

szaghi commented Aug 14, 2015

Yes, you are right, with custom compiler some other flagsare not opyional. I am very sorry, but I am on my holidays and I cannot do nothing gor improving the errors trapping. I will try next days if my family look on the other side...

@zbeekman
Copy link
Contributor Author

no worries, enjoy your holiday! I can actually just add the documentation myself in the wiki!

@zbeekman
Copy link
Contributor Author

Added to Homebrew!

I'm going to close it, since it's not really a bug. I'll try to update the wiki next week.

@szaghi
Copy link
Owner

szaghi commented Aug 15, 2015

Thank you very much Zaak!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants