Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modes error #7

Closed
Tobychev opened this issue Jul 9, 2014 · 5 comments
Closed

Modes error #7

Tobychev opened this issue Jul 9, 2014 · 5 comments

Comments

@Tobychev
Copy link
Contributor

Tobychev commented Jul 9, 2014

Hello Stefano,
when I try to build and make a typo in the mode name, there is no proper error handling, I'm just handed an stack trace and told that the section is missing.

It seems like it would be good to have something that catches this error and tells the user they entered the wrong mode name instead.

Thank you for your nice builder!

@szaghi
Copy link
Owner

szaghi commented Jul 9, 2014

Hi Tomas,

you are right, it is nice to have a deeper use-errors catching... I will try to implement such a feature tomorrow. Thank you for your help!

@szaghi
Copy link
Owner

szaghi commented Jul 10, 2014

Hi Tomas,

I have just uploaded a modified version that try to provide a more clear error message when typo in the modes name is inserted. As an example, if you try to build the cumbersome example with the following command

 FoBiS.py build -mode gnus

you will obtain (in bold character) the following error message

Error: fobos file has not mode named "gnus". Defined modes are:
  -) "gnu"
  -) "custom"

Is this the feature you request?

@Tobychev
Copy link
Contributor Author

Thank you, this is exactly what I asked for.

I do however find the "-)" a bit confusing, I think this is a very unusual way of indicating list items, and if it is a simple change I would prefer either "->" or plain "-", but it is not a real problem.

@szaghi
Copy link
Owner

szaghi commented Jul 10, 2014

Nice suggestion, I have opted for a plain "-".

See you soon.

@Tobychev
Copy link
Contributor Author

Looks nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants