Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catastrophic fail if a file is generated with the name of an output folder #58

Closed
sanguinariojoe opened this issue Jun 4, 2015 · 2 comments

Comments

@sanguinariojoe
Copy link

I have not checked that, but I love the 'Catastrophic' word, and I'm almost sure that it's gonna happen...

In _sanitize_dirs() (Builder.py:145) FoBiS is checking if the path already exist before trying to create that, however it is not checking if the path is a directory or a file...

Therefore, creating a fancy file, let's say 'obj', _sanitize_dirs() is detecting it as a valid path, skipping, and exploding later with a terrible error hiding...

Am I right??

Enough for today!

@szaghi
Copy link
Owner

szaghi commented Jun 5, 2015

This is very interesting, I think you are rigth!

In general I have a particular "fortune" for raising catastrophic error, but in this case I completely miss this :-)

Today I will test and fix this.

Thank you very much Pepe!

@szaghi
Copy link
Owner

szaghi commented Jun 8, 2015

Correct, and purged out all os.sep.

@szaghi szaghi closed this as completed Jun 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants