Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

os.path.join instead of os.sep? #57

Closed
sanguinariojoe opened this issue Jun 4, 2015 · 2 comments
Closed

os.path.join instead of os.sep? #57

sanguinariojoe opened this issue Jun 4, 2015 · 2 comments

Comments

@sanguinariojoe
Copy link

In _sanitize_dirs() (Builder.py:145), is it not more convenient using os.path.join() instead of manually concatenating os.sep separators?

@szaghi
Copy link
Owner

szaghi commented Jun 5, 2015

Sure, you are rigth!

Thank you Pepe

@szaghi
Copy link
Owner

szaghi commented Jun 8, 2015

Done, but not everywhere.

The abuse of os.sep was pervasive and now is reduced but not completely purged. For some cases I have preferred to explicitly add the separator add the end of some normalized paths because I have some paths concatenation done without os.path.join... Before purging out completely os.sep I have to find all paths concatenation... this will done during the next code refactoring.

@szaghi szaghi closed this as completed Jun 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants