Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce the number cycles when parsing #23

Closed
victorsndvg opened this issue Apr 22, 2015 · 4 comments
Closed

Reduce the number cycles when parsing #23

victorsndvg opened this issue Apr 22, 2015 · 4 comments

Comments

@victorsndvg
Copy link

Hello Stefano,

I was looking through the code searching for a bug (I will report it now) and I see that in:

The loop continues even after finding the switch in the CLI. The suggestion is to force to stop the loop at this point. I think this would reduce the complexity.

What do you think?

Best regards,
Víctor.

@szaghi
Copy link
Owner

szaghi commented Apr 22, 2015

You are right, but I have just strongly refactored this procedure (indeed all procedures).

I am uploading my testing version into a new version on Github repo, so you can see my progress, but this version has a very testing status...

@szaghi
Copy link
Owner

szaghi commented Apr 22, 2015

Now the procedure is inside the CLAg group and there is the exit statement for reducing the number of cycles:

https://github.com/szaghi/FLAP/blob/master/src/Data_Type_Command_Line_Interface.F90#L1212

@victorsndvg
Copy link
Author

Good job!
Sorry I think I've been very impatient ;)

@szaghi
Copy link
Owner

szaghi commented Apr 22, 2015

No, you are great!

I am too slow... but I am very busy.

@szaghi szaghi closed this as completed May 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants