Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue #145: When line items is enabled sometimes the generation fails #146

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jaapjansma
Copy link
Contributor

@jaapjansma jaapjansma commented Apr 12, 2022

Fix for issue #145: When line items is enabled sometimes the generation fails

Steps to reproduce

  1. Enable Line Items under Administer --> Administration Console --> Donation Receipts Profiles --> General Settings
  2. Setup a profile for the financial type donation
  3. Create a price set for event, with one field of financial type event fee and with a checkbox field with multiple options all of type donation
  4. Register a contact for this event and select at least two checkboxes (so that there are two or more line items for donations)
  5. Now try to generate a donation receipt

Expected behaviour

A donation receipt is created

Actual behaviour

An error is thrown, DB Error: already exists

@jensschuppe jensschuppe added this to the 2.2 milestone Nov 16, 2022
@jensschuppe jensschuppe added enhancement status:needs review Code needs review and testing. labels Nov 16, 2022
@jensschuppe
Copy link
Collaborator

@jaapjansma - thanks for your contribution and sorry this takes so long ... I think almost nobody but you is using the line item functionality - would you be able to get someone else review this?

Anyway this would be merged for 2.2, not for 2.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement status:needs review Code needs review and testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When line items is enabled sometimes the generation fails
2 participants