Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Giving mentors ability to review task checked by mentee before marking task complete #335

Closed
asawesome07 opened this issue Dec 11, 2019 · 3 comments
Labels
Category: Coding Changes to code base or refactored code that doesn't fix a bug. Status: Available Issue was approved and available to claim or abandoned for over 3 days. Type: Enhancement New feature or request.

Comments

@asawesome07
Copy link
Contributor

asawesome07 commented Dec 11, 2019

Is your feature request related to a problem? Please describe.
Right now, when a mentee checks a task in a relationship, it is marked complete instantly. Instead, It should go to the mentor for review and approval.

this is a feature request from app documentation: [Required] The mentors can agree if the elements on the checklist can be checked only by the mentee or must be approved.

Describe the solution you'd like
After mentee has checked a task, for the mentor, the task should come up in a new review tab in the relation page, here the mentor can approve the task checked by mentee before finally marking it complete.

@bartekpacia
Copy link
Contributor

This also needs some integration on the backend. How would we know whether the mentee is allowed to mark tasks as completed?
The relation model would need a new property, like independent_mentee: [bool]

@pknotfound
Copy link
Contributor

Is this issue still available?
May I work on this?

@aditmehta9 aditmehta9 added Category: Coding Changes to code base or refactored code that doesn't fix a bug. Status: Available Issue was approved and available to claim or abandoned for over 3 days. Type: Enhancement New feature or request. labels May 24, 2020
@aditmehta9
Copy link
Member

@asawesome07 I am closing this issue because similar issue is opened by @bartekpacia and he has sent PR for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Coding Changes to code base or refactored code that doesn't fix a bug. Status: Available Issue was approved and available to claim or abandoned for over 3 days. Type: Enhancement New feature or request.
Projects
None yet
Development

No branches or pull requests

4 participants