Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(theme-ui): Add support for sx prop to BaseStyles component #1470

Closed
lachlanjc opened this issue Jan 25, 2021 · 1 comment · Fixed by #2081
Closed

(theme-ui): Add support for sx prop to BaseStyles component #1470

lachlanjc opened this issue Jan 25, 2021 · 1 comment · Fixed by #2081
Labels
enhancement New feature or request good first issue Good for newcomers released This issue/pull request has been released.

Comments

@lachlanjc
Copy link
Member

Is your feature request related to a problem? Please describe.
It's frustrating to have any DOM nodes that don't allow styling, especially when they're provided by Theme UI.

Describe the solution you'd like
To be consistent with #1350, let's support sx on the BaseStyles component.

Additional context
https://github.com/system-ui/theme-ui/blob/develop/packages/theme-ui/src/index.ts#L27
@lachlanjc lachlanjc added the enhancement New feature or request label Jan 25, 2021
@hasparus hasparus added the good first issue Good for newcomers label Feb 16, 2021
@lachlanjc lachlanjc mentioned this issue Jan 17, 2022
Merged
@hasparus
Copy link
Member

🚀 Issue was released in v0.14.0 🚀

@hasparus hasparus added the released This issue/pull request has been released. label Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers released This issue/pull request has been released.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(theme-ui): Add sx prop to BaseStyles component system-ui/theme-ui
2 participants
@lachlanjc @hasparus