Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move protocol 7 Eeprom::Activity packets rendering to Activity class #163

Closed
Tracked by #111
synthead opened this issue Nov 26, 2022 · 0 comments · Fixed by #164
Closed
Tracked by #111

Move protocol 7 Eeprom::Activity packets rendering to Activity class #163

synthead opened this issue Nov 26, 2022 · 0 comments · Fixed by #164
Assignees
@synthead
Labels
enhancement New feature or request protocol 7 Specific to protocol 7

Comments

@synthead
Copy link
Owner

synthead commented Nov 26, 2022 •
edited
Loading

Instead of relying on protocol 7's Eeprom class to know how to handle compiling all the packets, move this responsibility to the Eeprom::Activity class as class methods. This can be called from the Eeprom class.
@synthead synthead mentioned this issue Nov 26, 2022
Closed
21 tasks
@synthead synthead added enhancement New feature or request protocol 7 Specific to protocol 7 labels Nov 26, 2022
@synthead synthead self-assigned this Nov 26, 2022
@synthead synthead mentioned this issue Nov 26, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@synthead synthead

Labels
enhancement New feature or request protocol 7 Specific to protocol 7
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add packets class method to Eeprom::Activity synthead/timex_datalink_client
1 participant
@synthead