System Prompts #70

Niduank · 2025-02-12T16:47:48Z

Important to know

Old system message

We re-use the old system message as a default non-editable and non-removable SystemPrompt called outputOnly.
SystemPrompt.outputOnly is inserted in SwiftData at app launch if there is no entry.

Settings

List is sorted by timestamp desc
Search bar will filter on SystemPrompt[.name, .prompt, .tags] containing text
When deleting the selected SystemPrompt, we will try to select the most recently used one or outputOnly

ContentView

We always display/use a system prompt

Suggested System Prompt

The suggestions are displayed asynchronously.
Each SystemPrompt's suggestion is calculated based on a score.

For each application:
+5 for a match with the active (frontmost) application
+5 for a match with the input application (selected text)
+5 for a match with the applications from auto-context

For each tag:
+3 for a match in the input (selected text)
+3 for a match in auto-context and context files

Misc

New KeyboardShortcutManager which observe, enable/disable keyboard shortcuts
Changes on ModelContainer & EnvironmentValues
Script clean_app.sh updated - was not deleting default.store* files after backup

greptile-apps

PR Summary

This PR implements a comprehensive system prompts feature with suggestion capabilities and keyboard shortcut integration.

Added SystemPromptSuggestionService in /macos/Onit/Data/Services/SystemPromptSuggestionService.swift that scores prompts based on app context and tags
Introduced SwiftDataContainer in /macos/Onit/Data/SwiftDataContainer.swift for managing persistent storage of Chat and SystemPrompt models
Added new UI components in /macos/Onit/UI/Prompt/SystemPrompt/ for managing and selecting system prompts
Centralized keyboard shortcut handling in /macos/Onit/KeyboardShortcuts/KeyboardShortcutsManager.swift
Improved cleanup script with safer file deletion logic in /macos/cleanup_app.sh

_{💡 (2/5) Greptile learns from your feedback when you react with 👍/👎!}

_{39 file(s) reviewed, 41 comment(s)}
_{Edit PR Review Bot Settings | Greptile}

greptile-apps · 2025-02-19T00:39:30Z

macos/Onit/Data/Model/Chat.swift

@@ -23,3 +23,7 @@ final class Chat {
        prompts.map { $0.fullText }.joined(separator: "\n")
    }
 }
+
+extension Chat {
+    @MainActor static let sample = Chat(prompts: [Prompt.sample])


style: Consider making sample private to prevent accidental usage in production code

Suggested change

@MainActor static let sample = Chat(prompts: [Prompt.sample])

@MainActor private static let sample = Chat(prompts: [Prompt.sample])

greptile-apps · 2025-02-19T00:39:39Z

macos/Onit/Assets.xcassets/Icons/chat-settings.imageset/Contents.json

+  "properties" : {
+    "preserves-vector-representation" : true
+  }


style: Missing 'template-rendering-intent': 'template' property that's present in pencil.imageset. This icon won't adapt to UI color schemes like dark/light mode.

Suggested change

"properties" : {

"preserves-vector-representation" : true

}

"properties" : {

"preserves-vector-representation" : true,

"template-rendering-intent" : "template"

}

greptile-apps · 2025-02-19T00:39:43Z

macos/Onit/App.swift

    init() {
-        KeyboardShortcuts.onKeyUp(for: .launch) { [weak model] in
-            let eventProperties: [String: Any] = [
-                "app_hidden": model?.panel == nil,
-                "highlight_hint_visible": HighlightHintWindowController.shared.isVisible(),
-                "highlight_hint_mode": FeatureFlagManager.shared.highlightHintMode,
-            ]
-            PostHogSDK.shared.capture("shortcut_launch", properties: eventProperties)
-
-            model?.launchShortcutAction()
-        }
-        KeyboardShortcuts.onKeyUp(for: .toggleLocalMode) { [weak model] in
-            model?.toggleLocalVsRemoteShortcutAction()
-        }
-        KeyboardShortcuts.onKeyUp(for: .newChat) { [weak model] in
-            model?.newChat()
-        }
-        KeyboardShortcuts.onKeyUp(for: .resizeWindow) { [weak model] in
-            model?.resizeWindow()
-        }
-        KeyboardShortcuts.onKeyUp(for: .escape) { [weak model] in
-            model?.escapeAction()
-        }
-        KeyboardShortcuts.onKeyUp(for: .launchWithAutoContext) { [weak model] in
-            let eventProperties: [String: Any] = [
-                "app_hidden": model?.panel == nil
-            ]
-            PostHogSDK.shared.capture(
-                "shortcut_launch_with_auto_context", properties: eventProperties)
-            model?.addAutoContext()
-            model?.launchPanel()
-        }
+        KeyboardShortcutsManager.configure(model: model)


logic: KeyboardShortcutsManager.configure() is called before model.showPanel(), but model is a weak reference in the manager. Consider reordering to ensure model is fully initialized

greptile-apps · 2025-02-19T00:40:05Z

macos/Onit/Data/Model/Model+Chat.swift

+            systemPrompt = try container.mainContext.fetch(FetchDescriptor<SystemPrompt>())
+                .first(where: { $0.id == Defaults[.systemPromptId] }) ?? SystemPrompt.outputOnly
+        } catch {


logic: No error handling for database fetch failure - could silently use outputOnly without logging the error

greptile-apps · 2025-02-19T00:40:06Z

macos/Onit/Data/Model/Model+Chat.swift


+                let systemPrompt = prompt.systemPrompt ?? SystemPrompt.outputOnly


style: Redundant fallback to SystemPrompt.outputOnly since it's already handled in prompt creation

Suggested change

let systemPrompt = prompt.systemPrompt ?? SystemPrompt.outputOnly

let systemPrompt = prompt.systemPrompt

greptile-apps · 2025-02-19T00:44:42Z

macos/Onit/UI/Settings/SystemPrompt/NewSystemPromptView.swift

+                            if !savedPrompt.applications.contains(url) {
+                                savedPrompt.applications.append(url)
+                            }


logic: redundant check - the allApps list is already filtered to exclude existing applications

Suggested change

if !savedPrompt.applications.contains(url) {

savedPrompt.applications.append(url)

}

savedPrompt.applications.append(url)

greptile-apps · 2025-02-19T00:44:42Z

macos/Onit/UI/Settings/SystemPrompt/SettingsSystemPromptDetail.swift

+                                    Image(nsImage: NSWorkspace.shared.icon(forFile: url.path))
+                                        .resizable()


style: Loading app icons synchronously could cause UI stutter. Consider async loading with placeholder.

greptile-apps · 2025-02-19T00:44:42Z

macos/Onit/UI/Settings/SystemPrompt/NewSystemPromptView.swift

+                    KeyboardShortcuts.Recorder(
+                        "Hotkey", name: KeyboardShortcuts.Name(savedPrompt.id)
+                    ) { shortcut in
+                        if isSaved {
+                            shortcutChanged.toggle()
+                        }
+                    }


logic: keyboard shortcut changes are only tracked when prompt is saved, but not during initial creation - could lead to shortcut conflicts

greptile-apps · 2025-02-19T00:44:59Z

macos/Onit/UI/Settings/SystemPrompt/SettingsSystemPromptTable.swift

+            prompts.filter {
+                $0.name.lowercased().contains(clearFilter) ||
+                $0.prompt.lowercased().contains(clearFilter) ||
+                $0.tags.joined(separator: ",").lowercased().contains(clearFilter)


logic: joined(separator: ",") creates a single string for tag search - could miss partial matches across tag boundaries

greptile-apps · 2025-02-19T00:45:23Z

macos/cleanup_app.sh

@@ -50,7 +50,7 @@ if [ -d "$DATABASE_PATH" ]; then
    find "$DATABASE_PATH" -type f -name "default.store*" -exec cp {} "$BACKUP_DIR" \; > /dev/null 2>&1


style: Consider adding -maxdepth option to find command to limit directory traversal depth

timlenardo · 2025-02-19T03:23:00Z

Hi @Niduank - overall this looks great! I have one big behavioral change to request:

Since the system prompts are a special case that are inserted only at the beginning of the chat messages, we shouldn't be able to change the system prompt once after the first message. The prompt should show up only once at the top of the chat, and not be editable in the "Follow-up" field:

To use a different system prompt, users will have to start a new chat.

This might create a confusing experience, so I asked Elise to add a message explaining why the system prompt can't be edited (and a 'start new chat' button). Design is here

* List, add, edit, remove * Search filters on name, prompt, tags * Persist with SwiftData

* Added a non-editable and non-deletable default SystemPrompt called "outputResponse" * Added the views SystemPromptView, SystemPromptSelectionView, and SystemPromptDetailView * Selection persists in UserDefaults * Used the selected prompt during a chat * Changed the management of EnvironmentValues * Changed the management of ModelContainer * Updated the script that was not deleting default.store* files

* No need of SwiftData migration, we fallback on 'outputOnly' * Save SystemPrompt in Prompt * Display it in GeneratedView

* Added timestamp & lastUsed dates to SystemPrompt * Sort SystemPrompts by timestamp in Settings & Selection * When we remove the current system prompt, fallback to last used or outputOnly * Fix random crash in Settings/SystemPrompt

* Display applications & tags correctly in a FlowLayout * Set max width 400 to new system prompt form

* Frontmost application (apps) * Input application (apps) * Input selected text (tags) * Auto context & file context (tags)

Niduank · 2025-02-19T14:42:43Z

Hi @Niduank - overall this looks great! I have one big behavioral change to request:

Since the system prompts are a special case that are inserted only at the beginning of the chat messages, we shouldn't be able to change the system prompt once after the first message. The prompt should show up only once at the top of the chat, and not be editable in the "Follow-up" field:
To use a different system prompt, users will have to start a new chat.
This might create a confusing experience, so I asked Elise to add a message explaining why the system prompt can't be edited (and a 'start new chat' button). Design is here

@timlenardo I made the changes, everything works as expected.
Just to be sure, do we still need to send the system with each prompt?
If so, feel free to merge it 👍

timlenardo · 2025-02-19T17:26:18Z

Hi @Niduank - Yes, the system prompt gets sent with each prompt, but it's static and always at the top of the message stack.

For example, if a user is sending a follow-up message, the stack will be:

System Prompt > 1st User Message > 1st LLM Reply > 2nd User message

timlenardo · 2025-02-20T05:43:06Z

Hey Kevin - this looks great! There are a few changes to the header that should go along with this, as shown in this design.

Basically:

The 'full screen' button moves to the top right
The 'new chat' button moves to the left
There should be an arrow next to the 'new chat' button
By default, the system prompt UI should NOT appear.
If Onit has automatically changed the system prompt (due to Application or Keyword or something else) it should show the system prompt UI.
If the user hovers over the down button next to the "new chat" button, the System prompt UI appears.
If the user clicks the down button next to the "New chat" button, there's a window to "start new chat with system prompt" and shows the interface for choosing a system prompt.

Also, when the first time I ran this, I got a crash. It's worked on subsequent runs, but here's the crash I got:

Base automatically changed from feature/streaming-support to main February 12, 2025 18:52

Niduank force-pushed the feature/system-prompts branch from db3f201 to 0f14648 Compare February 13, 2025 10:38

greptile-apps bot reviewed Feb 19, 2025

View reviewed changes

Niduank force-pushed the feature/system-prompts branch from 96a1178 to 82449c3 Compare February 19, 2025 10:01

Niduank added 15 commits February 19, 2025 15:08

System Prompts in Settings

ae51be7

* List, add, edit, remove * Search filters on name, prompt, tags * Persist with SwiftData

Fix SystemPromptDetailView width

c4f585e

On selected prompt deleted, fallback to outputOnly

a3be170

Added Hotkey implementation

9232f27

Update design

cb983df

SystemPrompt in GeneratedView

5bafef7

* No need of SwiftData migration, we fallback on 'outputOnly' * Save SystemPrompt in Prompt * Display it in GeneratedView

Prevent enter keyboard shortcut listener

e15ada3

Improvements

56f2283

* Added timestamp & lastUsed dates to SystemPrompt * Sort SystemPrompts by timestamp in Settings & Selection * When we remove the current system prompt, fallback to last used or outputOnly * Fix random crash in Settings/SystemPrompt

Adapt UI/UX

8035361

* Display applications & tags correctly in a FlowLayout * Set max width 400 to new system prompt form

Display suggested system prompt rely on

94702f5

* Frontmost application (apps) * Input application (apps) * Input selected text (tags) * Auto context & file context (tags)

Suggestions should rely on auto context app

56838df

Feedbacks from Greptile

a626442

Fix - Unique system prompt by chat

8eb29db

Fix prompt scrollable

9fcd050

Niduank force-pushed the feature/system-prompts branch from 1e0f069 to 9fcd050 Compare February 19, 2025 14:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

System Prompts #70

System Prompts #70

Niduank commented Feb 12, 2025

greptile-apps bot left a comment

greptile-apps bot Feb 19, 2025

greptile-apps bot Feb 19, 2025

greptile-apps bot Feb 19, 2025

greptile-apps bot Feb 19, 2025

greptile-apps bot Feb 19, 2025

greptile-apps bot Feb 19, 2025

greptile-apps bot Feb 19, 2025

greptile-apps bot Feb 19, 2025

greptile-apps bot Feb 19, 2025

greptile-apps bot Feb 19, 2025

timlenardo commented Feb 19, 2025

Niduank commented Feb 19, 2025 •

edited

Loading

timlenardo commented Feb 19, 2025

timlenardo commented Feb 20, 2025

	@MainActor static let sample = Chat(prompts: [Prompt.sample])
	@MainActor private static let sample = Chat(prompts: [Prompt.sample])


		let systemPrompt = prompt.systemPrompt ?? SystemPrompt.outputOnly

	let systemPrompt = prompt.systemPrompt ?? SystemPrompt.outputOnly
	let systemPrompt = prompt.systemPrompt

		Image(nsImage: NSWorkspace.shared.icon(forFile: url.path))
		.resizable()

		@@ -50,7 +50,7 @@ if [ -d "$DATABASE_PATH" ]; then
		find "$DATABASE_PATH" -type f -name "default.store*" -exec cp {} "$BACKUP_DIR" \; > /dev/null 2>&1

System Prompts #70

Are you sure you want to change the base?

System Prompts #70

Conversation

Niduank commented Feb 12, 2025

Important to know

Old system message

Settings

ContentView

Suggested System Prompt

Misc

greptile-apps bot left a comment

Choose a reason for hiding this comment

PR Summary

greptile-apps bot Feb 19, 2025

Choose a reason for hiding this comment

greptile-apps bot Feb 19, 2025

Choose a reason for hiding this comment

greptile-apps bot Feb 19, 2025

Choose a reason for hiding this comment

greptile-apps bot Feb 19, 2025

Choose a reason for hiding this comment

greptile-apps bot Feb 19, 2025

Choose a reason for hiding this comment

greptile-apps bot Feb 19, 2025

Choose a reason for hiding this comment

greptile-apps bot Feb 19, 2025

Choose a reason for hiding this comment

greptile-apps bot Feb 19, 2025

Choose a reason for hiding this comment

greptile-apps bot Feb 19, 2025

Choose a reason for hiding this comment

greptile-apps bot Feb 19, 2025

Choose a reason for hiding this comment

timlenardo commented Feb 19, 2025

Niduank commented Feb 19, 2025 • edited Loading

timlenardo commented Feb 19, 2025

timlenardo commented Feb 20, 2025

Niduank commented Feb 19, 2025 •

edited

Loading