hey @alparslanavci, thanks for the PR. The code looks good and, apart from what you raised in #301, nothing much to worry here. We could try to avoid the potential race condition by making the dynamic controller verify the promise conditions (it has to fetch the promise anyway)-- so that might be a better approach.

however, what we are actually debating is whether we want this feature at all. Gotta chat with the team and get back to you here!

Thanks again!

Thanks for the review, @kirederik! I agree with verifying the promise conditions on the dynamic resource controller. It would be a better approach.

No worries about the feature discussion, just let me know if you want to close the PR. 👍

BTW, it might be better to add a new flag on Promise to leave the "reconcile resource requests while a Promise pipeline is in-flight" decision to the user. This will allow the user to opt between availability and consistency.

Alright!

We debated a bit and decided that this is not really something we should incorporate into the product right now.

I'm going to close this PR for the moment. We will get back to it if things change!

Thanks again