Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

process should error out on printurl #359

Closed
synfinatic opened this issue May 3, 2022 · 1 comment · Fixed by #363
Closed

process should error out on printurl #359

synfinatic opened this issue May 3, 2022 · 1 comment · Fixed by #363
Labels
enhancement New feature or request
Milestone
1.9.0

Comments

@synfinatic
Copy link
Owner

I think the AWS process_command will let users see things written to stderr, so we should be able to support printing urls?
@synfinatic synfinatic added the enhancement New feature or request label May 3, 2022
@synfinatic synfinatic added this to the 1.8.2 milestone May 3, 2022
@synfinatic
Copy link
Owner Author

synfinatic commented May 5, 2022 •
edited
Loading

No, it only prints stderr when your program exits incorrectly :(

Also, the code was only checking for print, not printurl. if users manually set --url-action printurl then the aws call would hang.

@synfinatic synfinatic changed the title process works with stderr ? process should error out on printurl May 5, 2022
@synfinatic synfinatic mentioned this issue May 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
1.9.0
Development

Successfully merging a pull request may close this issue.

process command now correctly errors out on printurl synfinatic/aws-sso-cli
1 participant
@synfinatic