sympy-bot sometimes does not report doctest failures

[ness01]

In a recent pull request, I ran the bot and it reported no failuers [0]. However, there was a doctest failure in the tutorial.

[0] http://reviews.sympy.org/report/agZzeW1weTNyDAsSBFRhc2sYn8wLDA

Note that the bot reports failure, because the mathml test indeed fails. But the doctest fails too, without being reported!

[asmeurer]

Is it returning non-zero? That's how it checks if the tests failed or not.

[asmeurer]

Do you happen to still have the log locally in your terminal history? The return code will be printed there (but it's not included in the report).

[ness01]

Sorry for being so unresponsive; I'm quite busy with uni. Since sympy-bot reported "fail" anyway (due to the mathml test). The bin/doctest command does return non-zero, if this is what you are asking.

[NB this can be tested, for example, in commit dfb0dfa.]

[asmeurer]

I must have misread the logic in SymPy-bot then, because it looked like it reports failure based solely on the exit value.

[MichaelMayorov]

Hi, currently I collect ideas for my GSoC proposal about improving functionality and fixing bugs in sympy-bot.

ness01, sympy/sympy-bot@dfb0dfa is no longer valid and gives 404, I'll thank to you if you could help me to reproduce it.

[ness01]

no it's a sympy commit: sympy/sympy@dfb0dfa

[MichaelMayorov]

ok, I asked because in sympy/sympy-bot#94 (comment) you referred to sympy-bot

[ness01]

That link was auto-created by github.

You should be able to verify this issue by checking out said sympy
commit and running sympy-bot on it.

On 26.03.2012 13:49, Michael Mayorov wrote:

ok, I asked because in sympy/sympy-bot#94 (comment) you referred to sympy-bot

---

Reply to this email directly or view it on GitHub:
sympy/sympy-bot#94 (comment)

[asmeurer]

You should be able to verify this issue by checking out said sympy
commit and running sympy-bot on it.

Which is actually non-trivial to do, so you should also add a way to do this in sympy-bot.