This repository has been archived by the owner on Dec 3, 2023. It is now read-only.
[CS] Fixes #2517 Add Handle useless method comment in RemoveUselessClassCommentFixer #2522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsonasik
commented
Nov 19, 2020
packages/coding-standard/src/Fixer/Commenting/RemoveUselessClassCommentFixer.php
Show resolved
Hide resolved
|
Split test error seems unrelated : Problem 1
- Root composer.json requires rector/simple-php-doc-parser ^0.8.56 -> satisfiable by rector/simple-php-doc-parser[0.8.56].
- rector/simple-php-doc-parser 0.8.56 requires symplify/package-builder ^8.3.48 -> satisfiable by symplify/package-builder[8.3.48] from composer repo (https://repo.packagist.org) but symplify/package-builder[dev-master, 9.0.x-dev (alias of dev-master)] from path repo (../../packages/package-builder) has higher repository priority. The packages with higher priority do not match your constraint and are therefore not installable. See https://getcomposer.org/repoprio for details and assistance. |
samsonasik
force-pushed
the
fix-2517-add-fixer-useless-comment-method
branch
from
008570a to
8237ac5
Compare
...Fixer/Commenting/RemoveUselessClassCommentFixer/Fixture/useless_class_method_comment.php.inc
Show resolved
Hide resolved
samsonasik
force-pushed
the
fix-2517-add-fixer-useless-comment-method
branch
2 times, most recently
from
1cc159a to
180ed6a
Compare
…assCommentFixer
samsonasik
force-pushed
the
fix-2517-add-fixer-useless-comment-method
branch
from
e25a717 to
dc95a0c
Compare
|
@TomasVotruba I think it is ready, split test error is unrelated. |
|
Thank you 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.