Component Routing 2.6 composer package is missing a dependency

[sk-sparhandy]

It seams to me that at least one Class of the Routing Component 2.6 has a hard dependency on the ExpressionLanguage Component.

Symfony\Component\Routing\Matcher\UrlMatcher requires the presence of Symfony\Component\ExpressionLanguage\ExpressionFunctionProviderInterface (line 21 and 119)

The Packagist package definition of Routing Component does not contain this aspect. (Only in "Requires (Dev)" but that is not enough!)

[xabbuh]

@sk-sparhandy Did you experience any real issues (errors, etc.)? Because as far as I can see, there's no hard dependency on the ExpressionLanguage component if you don't make use of this optional feature.

[sk-sparhandy]

@xabbuh Install the Routing Component by composer and instantiate a mock object with the getMock Method of PHPUnit 3.7.

$mockedUrlMatcher = $this->getMock(
    'Symfony\\Component\\Routing\\Matcher\\UrlMatcher', array(), array(), '', false
);

will result in

Declaration of Mock_UrlMatcher_9e416bac::addExpressionLanguageProvider() should be compatible 
with Symfony\Component\Routing\Matcher\UrlMatcher::addExpressionLanguageProvider
(Symfony\Component\ExpressionLanguage\ExpressionFunctionProviderInterface $provider)

which leads to a failed UnitTest.

[xabbuh]

@sk-sparhandy You can workaround this by explicitly passing the methods to mock (see #12088 or FriendsOfSymfony/FOSRestBundle#914 for examples how to do that). This may not be ideal, but I don't think it's something to fix in the Routing component.

[sk-sparhandy]

If you do not want to change the implementation would you consider adding ExpressionLanguage Component as a dependency as long as the not ideal situation remains?

The current implementation strikes me as very unusual requiring extra effort to handle the class. I would be more then willing to offer a pull request dealing with this issue as you see fit.

[fabpot]

ExpressionLanguage is as a soft dependency as the component can work without it, that's why we did not add it as a requirement. The UrlMatcher class works (when using it) without the dependency; it's true that when mocking it, you might have a problem if not doing what @xabbuh suggests.

[stof]

Note that only PHPUnit_MockObject requires the ExpressionLanguage to be there to mock the class. Both Prophecy and Mockery are handling this better