Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symfony Standard Edition does not include Doctrine Bundles #3164

Closed
bicpi opened this issue Nov 6, 2013 · 15 comments
Closed

Symfony Standard Edition does not include Doctrine Bundles #3164

bicpi opened this issue Nov 6, 2013 · 15 comments
Labels

Comments

@bicpi
Copy link
Contributor

bicpi commented Nov 6, 2013

Why does doc/current/bundles/index.html say that the Symfony Standard Edition comes with the three Doctrine bundles listed below?

@bicpi
Copy link
Contributor Author

bicpi commented Nov 17, 2013

My proposal is to list the bundles that are really included in the Symfony Standard Edition:

  • FrameworkBundle
  • SecurityBundle
  • TwigBundle
  • MonologBundle
  • SwiftmailerBundle
  • AsseticBundle
  • DoctrineBundle
  • SensioFrameworkExtraBundle

And maybe marked as dev bundles:

  • AcmeDemoBundle
  • WebProfilerBundle
  • SensioDistributionBundle
  • SensioGeneratorBundle

All other bundles that are mentioned in the docs could be listed within an additional section for popular/important/interesting bundles:

  • DoctrineFixturesBundle
  • DoctrineMigrationsBundle
  • DoctrineMongoDBBundle
  • FOSUserBundle
  • JMSSecurityExtraBundle

The question is what doc links to use for some of them.

Maybe it would be cool to use a definition list style, so every bundle has a quick definition about what it is used for.

Please let me know what you think and I can set up a WIP PR for this.

@wouterj
Copy link
Member

wouterj commented Nov 17, 2013

I think the "popular" listing is far from complete. I also think we should move the doctrine bundle docs to the doctrine-project.org website, instead of rendering them on the symfony.com website. /cc @beberlei

Also, almost all bundles of the first list are included in the docs. I don't think we should list them here.

@bicpi
Copy link
Contributor Author

bicpi commented Nov 17, 2013

So maybe the whole "Bundles" page is obsolete?
But is there a good overview elsewhere in the docs for a new user what bundles are included in Symfony Standard? Isn't it a good index to quickly find the docs for a bundle?

In the "popular" list I tried to list all bundles that are currently mentioned in the docs. Of course, this list could be endless otherwise. So it would be easier to remove the complete list.

@wouterj
Copy link
Member

wouterj commented Nov 17, 2013

I think the populair list is already on knpbundles.com, there is no need to add it to our docs.

I think the only reason there is a Bundles page is because those 3th party bundles currently aren't rendered on another website. That's the reason why I think we should move the doctrine bundles to their site.

The only bundles that are left then are the sensio labs bundles. And because this docs is somewhat the Sensio labs documentation, I think it's best to leave them here and rename the section to "Sensiolabs Bundles" or something like that.

@weaverryan
Copy link
Member

Like @wouterj said, the reason this page exists is because some 3rd party bundles render their docs at symfony.com, and this page is meant to hold those. So I think that the only thing that's needed is maybe a wording change at the top of the page. I don't see the advantage of making the Doctrine guys go through the work of hosting the docs on their site and adding 301 redirects from symfony.com just to make this page more consistent :).

So my vote is to change the wording on this page and that's it :). Though, I don't know if that wording is actually available in any repository (docs or symfony-marketing).

@bicpi
Copy link
Contributor Author

bicpi commented Nov 25, 2013

I tried to do this update and so to find the content in the docs and the marketing repository, but with no success. the /index.rst of the docs holds some similiar content, but due to some typos it does not seem to be taken from there.

Any idea if I can find it somewhere else? Otherwise I don't know if we may close this issue or find someone else who can tweak the wording a bit so that it becomes true.

@wouterj
Copy link
Member

wouterj commented Nov 25, 2013

At last, @fabpot can change everything on the website. :-)

If it's not here, it can be available in symfony/symfony-marketing and otherwise we don't have access to it.

@fabpot
Copy link
Member

fabpot commented Nov 25, 2013

I will have a look at this soon. I mean, that's more a strategic change than anything else. I have some ideas to "fix" this issue nicely, but I need to think about it a bit more.

@bicpi
Copy link
Contributor Author

bicpi commented Nov 25, 2013

So let's wait until the magic happens :-) Thank you.

@xabbuh
Copy link
Member

xabbuh commented Nov 12, 2014

Should we think about this again now that #4106 is merged?

/cc @fabpot

@wouterj
Copy link
Member

wouterj commented Dec 13, 2014

@javiereguiluz / @fabpot can you please update the introduction on http://symfony.com/doc/bundles/ to not say "The Symfony Standard Edition comes with some bundles. Learn more about them.", as the bundles listed are not all comming with the SE?

@javiereguiluz
Copy link
Member

I'll take care of this issue.

@javiereguiluz
Copy link
Member

The introduction of the bundles section has been fixed as suggested by @wouterj It will be online after the next website deploy.

@javiereguiluz
Copy link
Member

This is now fixed. If you agree with the change, please close this issue. Thanks!

@xabbuh
Copy link
Member

xabbuh commented Dec 16, 2014

I like it. Than you, Javier!

@wouterj If you don't agree, please reopen.

@xabbuh xabbuh closed this as completed Dec 16, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants