Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: symfony/rate-limiter
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v6.4.14
Choose a base ref
...
head repository: symfony/rate-limiter
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v6.4.15
Choose a head ref
  • 4 commits
  • 3 files changed
  • 3 contributors

Commits on Oct 18, 2024

  1. Copy the full SHA
    bb40d7f View commit details

Commits on Nov 7, 2024

  1. handle error results of DateTime::modify()

    Depending on the version of PHP the modify() method will either throw an
    exception or issue a warning.
    xabbuh committed Nov 7, 2024
    Copy the full SHA
    c902bf7 View commit details

Commits on Nov 8, 2024

  1. Merge branch '5.4' into 6.4

    * 5.4:
      relax format assertions for fstat() results on Windows
      update ICU data from 75.1 to 76.1
      fix referencing the SYMFONY_VERSION env var
      handle error results of DateTime::modify()
    xabbuh committed Nov 8, 2024
    Copy the full SHA
    7171216 View commit details

Commits on Nov 9, 2024

  1. bug #58601 [RateLimiter] Fix bucket size reduced when previously crea…

    …ted with bigger size (Orkin)
    
    This PR was merged into the 6.4 branch.
    
    Discussion
    ----------
    
    [RateLimiter] Fix bucket size reduced when previously created with bigger size
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 6.4
    | Bug fix?      | yes
    | New feature?  | no
    | Deprecations? | no
    | Issues        | Fix #
    | License       | MIT
    
    ```yaml
    foo:
          policy: 'token_bucket'
          limit: 1000
          rate: { interval: '15 minutes', amount: 5 }
          cache_pool: rate_limiter.cache_pool
          lock_factory: 'lock.rate_limiter.factory'
    ```
    `rate_limiter.cache_pool` => it's a persistent cache pool like redis
    
    When using previously this configuration and consume the token bucket with 1 token it was save on the storage with 999 tokens available.
    
    If you update the configuration with a lower token limit
    ```yaml
    foo:
          policy: 'token_bucket'
          limit: 10
          rate: { interval: '15 minutes', amount: 5 }
          cache_pool: rate_limiter.cache_pool
          lock_factory: 'lock.rate_limiter.factory'
    ```
    
    You can consume 999 tokens before triggering the bucket limit without flushing the cache. The purpose of this PR is to update and use the new configuration limit.
    
    Commits
    -------
    
    6c34c5824fa Fix bucket size reduce when previously created with bigger size
    fabpot committed Nov 9, 2024
    Copy the full SHA
    e250d82 View commit details
Loading