Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elastica v8 Compatibility #499

Open
Kenneth-Sills opened this issue Feb 4, 2025 · 1 comment
Open

Elastica v8 Compatibility #499

Kenneth-Sills opened this issue Feb 4, 2025 · 1 comment

Comments

@Kenneth-Sills
Copy link

The upstream Elastica project released version 8 last year, changing the client initialization from taking host to hosts and removing port entirely.

Upstream supports this version, but our initialization logic still uses the old parameters and if someone uses the latest version it will silently default to localhost:9200.

We currently have no unit tests for elastica handlers.

@Kenneth-Sills
Copy link
Author

Ah, I went to make a PR but this one may be a bit more involved. Since v8 drops older PHP version support that we still target, we'll likely want to continue allowing for v7. However, the newer client has a changed public interface and the configuration looks fairly different than before in ways not covered by the upgrade guide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant