Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make:user & password_hashers: skip password_hashers update if possible #990

Closed
weaverryan opened this issue Oct 11, 2021 · 0 comments · Fixed by #1107
Closed

make:user & password_hashers: skip password_hashers update if possible #990

weaverryan opened this issue Oct 11, 2021 · 0 comments · Fixed by #1107
Labels
Feature New Feature HasPR

Comments

@weaverryan
Copy link
Member

Hi!

The latest security-bundle recipe comes with a security.yaml file containing this out of the box:

security:
    # ...

    # https://symfony.com/doc/current/security.html#c-hashing-passwords
    password_hashers:
        Symfony\Component\Security\Core\User\PasswordAuthenticatedUserInterface: 'auto'

And so, when make:user is executed (with "yes" for password), we do not need to update the password hasher. In other words, what we do now is this:

security:
    password_hashers:
        Symfony\Component\Security\Core\User\PasswordAuthenticatedUserInterface: 'auto'
+        App\Entity\User:
+            algorithm: auto

Those 2 new lines should not be added if PasswordAuthenticatedUserInterface is already present, as they are just not needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New Feature HasPR
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants