Skip to content

Commit 235ee15

Browse files
committed
fix test to actually use data provider
1 parent f765bc6 commit 235ee15

File tree

4 files changed

+7
-13
lines changed

4 files changed

+7
-13
lines changed

Tests/DependencyInjection/Fixtures/php/cache_app_redis_tag_aware_pool.php

+1-4
Original file line numberDiff line numberDiff line change
@@ -2,14 +2,11 @@
22

33
$container->loadFromExtension('framework', [
44
'cache' => [
5-
'app' => 'cache.redis_tag_aware.bar',
5+
'app' => 'cache.redis_tag_aware.foo',
66
'pools' => [
77
'cache.redis_tag_aware.foo' => [
88
'adapter' => 'cache.adapter.redis_tag_aware',
99
],
10-
'cache.redis_tag_aware.bar' => [
11-
'adapter' => 'cache.redis_tag_aware.foo',
12-
],
1310
],
1411
],
1512
]);

Tests/DependencyInjection/Fixtures/xml/cache_app_redis_tag_aware_pool.xml

+1-2
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,8 @@
77

88
<framework:config>
99
<framework:cache>
10-
<framework:app>cache.redis_tag_aware.bar</framework:app>
10+
<framework:app>cache.redis_tag_aware.foo</framework:app>
1111
<framework:pool name="cache.redis_tag_aware.foo" adapter="cache.adapter.redis_tag_aware" />
12-
<framework:pool name="cache.redis_tag_aware.bar" adapter="cache.redis_tag_aware.foo" />
1312
</framework:cache>
1413
</framework:config>
1514
</container>
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
framework:
22
cache:
3-
app: cache.redis_tag_aware.bar
3+
app: cache.redis_tag_aware.foo
44
pools:
55
cache.redis_tag_aware.foo:
66
adapter: cache.adapter.redis_tag_aware
7-
cache.redis_tag_aware.bar:
8-
adapter: cache.redis_tag_aware.foo

Tests/DependencyInjection/FrameworkExtensionTest.php

+4-4
Original file line numberDiff line numberDiff line change
@@ -1588,11 +1588,11 @@ public function testRedisTagAwareAdapter()
15881588
}
15891589

15901590
/**
1591-
* @dataProvider testAppRedisTagAwareConfigProvider
1591+
* @dataProvider appRedisTagAwareConfigProvider
15921592
*/
1593-
public function testAppRedisTagAwareAdapter()
1593+
public function testAppRedisTagAwareAdapter(string $configFile)
15941594
{
1595-
$container = $this->createContainerFromFile('cache_app_redis_tag_aware');
1595+
$container = $this->createContainerFromFile($configFile);
15961596

15971597
foreach ([TagAwareCacheInterface::class, CacheInterface::class, CacheItemPoolInterface::class] as $alias) {
15981598
$def = $container->findDefinition($alias);
@@ -1605,7 +1605,7 @@ public function testAppRedisTagAwareAdapter()
16051605
}
16061606
}
16071607

1608-
public function testAppRedisTagAwareConfigProvider(): array
1608+
public function appRedisTagAwareConfigProvider(): array
16091609
{
16101610
return [
16111611
['cache_app_redis_tag_aware'],

0 commit comments

Comments
 (0)