-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A failing action prevents it's subsequent transition from affecting workflow state #359
Comments
This may be an underlying cause to #358 |
Testing again recently, this issue only seems to manifest if the users have invalid email addresses. e.g. default admin being I presume there was still an issue sending an email since I have no mail server, but the workflow processed through as expected. This indicates a change in the Mailer interface being the root of the issue, where swiftmailer now expects well formed email addresses, and throws errors if they're not (where as the SilverStripe 3.x mailer was more tolerant of this). |
Also having recreated this now, it is the cause of #358 - an approval user can still 'manually' step through the workflow until such point as there is no next step, e.g. in the default
Trying to see if there was a user based workaround I ran into #366 - I could not delete the blocked workflow to free up editing on the page. |
I've confirmed this to be a direct result of attempting to send an email to an invalid email address (e.g. |
Setting up Advanced Workflow for a demonstrative run through in order to regression test, I've found that the 5.x line will hang up and seemingly offer limited actions than expected upon submitting for approval.
In reality what has happened is that my installation has failed to send an email, and the workflow has failed to progress.
This is different from 4.0.1 in that I received a toast notification in the CMS declaring an issue with Mailer.php, but then still presenting me with the expected next step action of approve or reject changes.
The text was updated successfully, but these errors were encountered: