fix: correct the range check for descriptor IDs

tri-adam · tri-adam · commit c1fcc374888b · 2024-08-23T15:58:27.000Z
diff --git a/pkg/sif/create.go b/pkg/sif/create.go
@@ -97,7 +97,7 @@ func (f *FileImage) writeDataObject(i int, di DescriptorInput, t time.Time) erro
 	}
 
 	// We derive the ID from i, so make sure the ID will not overflow.
-	if i >= math.MaxInt32 {
+	if int64(i) >= math.MaxUint32 {
 		return errObjectIDOverflow
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -97,7 +97,7 @@ func (f *FileImage) writeDataObject(i int, di DescriptorInput, t time.Time) erro`
`97`	`97`	`}`
`98`	`98`
`99`	`99`	`// We derive the ID from i, so make sure the ID will not overflow.`
`100`		`- if i >= math.MaxInt32 {`
	`100`	`+ if int64(i) >= math.MaxUint32 {`
`101`	`101`	`return errObjectIDOverflow`
`102`	`102`	`}`
`103`	`103`