github layer: magit keys missing from the magit help

[tko]

github layer adds a few keybindings in magit-status-mode. However, those keys are not behaving like magit keys otherwise; they don't show up in the list of keys/commands you see with ?, when you hit the new # command/prefix key you still don't get any further guidance, neither from magit nor from guide-key.

[tko]

Something along the lines of

(magit-key-mode-insert-action 'dispatch (kbd "#") "GitHub-PR" 'magit-key-mode-popup-github)

might work (ref: emacsorphanage/magit-gerrit#17) .. might need to implement the popup as well, I guess.

[TheBB]

The proposed code doesn't work in the new version of Magit, but you can use magit-define-popup-key and magit-change-popup-key to get the same effect.

Unfortunately it's not so clear how to do this in a way that works with both evilified and emacs state. Simplest would be to go with one of them on startup and say that if you switch while Spacemacs is running, that's your own problem.

[tarsius]

those keys [...] don't show up in the list of keys/commands you see with ?

Since this doesn't affect only Spacemacs, the respective bindings should be established in the upstream packages.

For magit-gh-pulls I have done so at sigma/magit-gh-pulls#96. Someone(tm) please do that for the other extensions. See that pr for how to do it.

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Please let us know if this issue is still valid!