implement tests for resource policy custom methods

Signed-off-by: Stephane Selim <stephane.selim@swisscom.com>
swisscom · Aug 12, 2024 · 2c8efc7 · 2c8efc7
1 parent 5324d2a
commit 2c8efc7
Show file tree

Hide file tree

Showing 2 changed files with 409 additions and 4 deletions.
diff --git a/pkg/controller/cloudwatchlogs/resourcepolicy/setup.go b/pkg/controller/cloudwatchlogs/resourcepolicy/setup.go
@@ -80,10 +80,15 @@ func postObserve(_ context.Context, cr *svcapitypes.ResourcePolicy, _ *svcsdk.De
 }
 
 func isUpToDate(_ context.Context, cr *svcapitypes.ResourcePolicy, obj *svcsdk.DescribeResourcePoliciesOutput) (bool, string, error) {
-	if len(obj.ResourcePolicies) == 0 {
+	if obj == nil || len(obj.ResourcePolicies) == 0 {
 		return false, "", nil
 	}
 
+	if cr == nil || cr.Spec.ForProvider.PolicyDocument == nil {
+		return false, "", nil
+	}
+
+	// Check if the policy exists
 	for _, policy := range obj.ResourcePolicies {
 		if policy.PolicyName != nil && *policy.PolicyName == meta.GetExternalName(cr) {
 			// Use existing method from iam to compare policy documents
@@ -93,11 +98,20 @@ func isUpToDate(_ context.Context, cr *svcapitypes.ResourcePolicy, obj *svcsdk.D
 	return false, "", nil
 }
 
-func filterList(cr *svcapitypes.ResourcePolicy, list *svcsdk.DescribeResourcePoliciesOutput) *svcsdk.DescribeResourcePoliciesOutput {
+func filterList(cr *svcapitypes.ResourcePolicy, obj *svcsdk.DescribeResourcePoliciesOutput) *svcsdk.DescribeResourcePoliciesOutput {
 	resp := &svcsdk.DescribeResourcePoliciesOutput{}
+	if obj == nil || len(obj.ResourcePolicies) == 0 {
+		return resp
+	}
+
+	if cr == nil {
+		return resp
+	}
+
+	resourcePolicyIdentifier := pointer.ToOrNilIfZeroValue(meta.GetExternalName(cr))
 
-	for _, resourcePolicy := range list.ResourcePolicies {
-		if pointer.StringValue(resourcePolicy.PolicyName) == meta.GetExternalName(cr) {
+	for _, resourcePolicy := range obj.ResourcePolicies {
+		if pointer.StringValue(resourcePolicy.PolicyName) == pointer.StringValue(resourcePolicyIdentifier) {
 			resp.ResourcePolicies = append(resp.ResourcePolicies, resourcePolicy)
 			break
 		}