Bug: Stateful regex problem

[Xiphe]

When I use a regex with global flag, I get unexpected results since rgx.test is used to test against the asset path.

See https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/RegExp/test#using_test_on_a_regex_with_the_global_flag for details on this.

Solution would be to use Boolean(asset.match((pattern as RegExp)) here

I'll happily provide a PR for this.

[swimmadude66]

I appreciate the call-out! I will evaluate this tonight, but I am curious: What benefit is there to passing a global regex as the pattern? Would it cause any issues with your usecase if we simply force the global flag to false before running the regex test?

[swimmadude66]

Fixed in Release v 1.0.1

https://github.com/swimmadude66/html-webpack-skip-assets-plugin/releases/tag/1.0.1

[Xiphe]

Cool! Thanks for fixing this.
Regarding the use-case: In my case I could probably just omit the global flag and I cant really think of a good situation where this would enable something.

The benefit of having this fixed is more about predictability, I guess.
I was just irritated why the plugin behaved this way and then needed to debug until I landed here. So I assume the fix will at least save others some time that just blindly add a global flag to their regexp :)

[swimmadude66]

Absolutely a good point. I ended up using .match as you suggested anyways, but I wanted to make sure I was covering all bases. Thanks again for bringing this up, I never knew about that quirk of regexp.test!

[Xiphe]

I also forget about that all the time :) Thanks again 👍