Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All check box and Radio buttons in app are hidden due to css #943

Open
anthonysubramani opened this issue Aug 30, 2017 · 4 comments
Open

Comments

@anthonysubramani
Copy link

anthonysubramani commented Aug 30, 2017

I'm submitting a ... (check one with "x")

[x] bug report => search github for a similar issue or PR before submitting
[ ] feature request
[ ] support request => Please do not submit support request here, post on Stackoverflow or Gitter

Current behavior

All check box and Radio buttons in app are hidden due to this css
input[type="checkbox"], input[type="radio"] { display: none; } in file
@swimlane/ngx-datatable/release/themes/material.css
Expected behavior

Check boxes should be visible
Reproduction of the problem

checkbox not display in demo
http://swimlane.github.io/ngx-datatable/#chkbox-selection
What is the motivation / use case for changing the behavior?

Please tell us about your environment:

  • Table version: 0.8.x
  • Angular version: 2.0.x
  • Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]
  • Language: [all | TypeScript X.X | ES6/7 | ES5]
@Debananda
Copy link

Adding to the problem : As the checkbox styling is given on a generic way (without defined inside a class) it also affects the whole consuming project

@tnarp
Copy link

tnarp commented Sep 3, 2017

input[type="checkbox"], input[type="radio"] { display: none; }
modify to
input[type="checkbox"], input[type="radio"] { display: block; }
then the checkbox can show

if you use angular2+, you can add css below where use ngx-datatable
:host /deep/ input[type='checkbox'] { display: block !important; }

@anthonysubramani
Copy link
Author

anthonysubramani commented Sep 5, 2017

@monica7l @tnarp the solution is evident, but this needs to be changed in the source itself. Also inputs are inline element so adding display: block !important will make it even worse. so it should be associated with inline style

@monica7l
Copy link

monica7l commented Sep 5, 2017

I agree this has to be fixed in ngx-datatable itself. In the mean time I closed my #952 because it was a duplicate of this one.

@Jotakuun Jotakuun mentioned this issue Sep 5, 2017
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants