Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Columns duplicate when dragging to re-order more than one column away from original position #576

Closed
Dedac opened this issue Mar 1, 2017 · 5 comments

Comments

@Dedac
Copy link

Dedac commented Mar 1, 2017

I'm submitting a ... (check one with "x")

[X] bug report => search github for a similar issue or PR before submitting
[ ] feature request
[ ] support request => Please do not submit support request here

Current behavior

When dragging columns (see demos that are draggable), if you drag a column more than one column away, that column is duplicated in the grid. If you drag it further away from its original position, you can get multiple column duplications
Expected behavior

columns are not duplicated on drag to re-order

Reproduction of the problem

http://swimlane.github.io/ngx-datatable/#
The full screen demo makes it easy to reproduce.

What is the motivation / use case for changing the behavior?

Users only want one of each column

Please tell us about your environment:

  • Table version: 0.7.x

6.3.0

  • Angular version: 2.0.x

Whatever you have on the demo site

  • Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]

Chrome, Safari

  • Language: [all | TypeScript X.X | ES6/7 | ES5]
    all
@gerhardboer
Copy link
Contributor

I have a fix for this and submitted the pull-request #563 .
I don't know why it hasn't been merged yet, maybe they want to see what Angular v4 fixes for them before they merge bigger pull-requests.

If you have this issue in a real world application (not just the demo's), maybe you could check if my changes fix the issue for you?

@Dedac
Copy link
Author

Dedac commented Mar 2, 2017

Sorry, I didn't see the original bug after seeing that bug #562 was closed. This is a duplicate of bug #497.
@amcdnl, is there any reason you are not merging PR #563?

@Dedac
Copy link
Author

Dedac commented Mar 2, 2017

If it matters this and the dynamic pinning are still problems in angular 4 rc2

@gerhardboer
Copy link
Contributor

@Dedac
it's cool. I was commenting to get more traction on my pull-request :)

@amcdnl amcdnl added this to the 7.0.0 milestone Mar 4, 2017
@amcdnl amcdnl self-assigned this Mar 4, 2017
@amcdnl
Copy link
Contributor

amcdnl commented Mar 7, 2017

Merged @gerhardboer - Please retest :)

@amcdnl amcdnl closed this as completed Mar 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants